In the shutdown function logging an error if debug was not able to write to the memcache debug log, the watchdog call uses undefined variable $memcache_debug_file.

Considering the logic of that function, it seems the variable should be $memcache_debug_log instead.

CommentFileSizeAuthor
#9 3044847-2b.patch1.88 KBjeremy
#8 3044847-2.patch2.19 KBjeremy
#7 3044847.patch2.04 KBjeremy
#6 3044847-dmemcache-write-debug-6-D7.patch2.02 KBsokru
#3 0001-Issue-3044847-by-fgm-_dmemcache_write_debug-uses-und.patch2.4 KBfgm
#2 0001-Issue-3044847-by-fgm-_dmemcache_write_debug-uses-und.patch1.34 KBfgm

Comments

fgm created an issue. See original summary.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Active » Needs review
StatusFileSize
new 0001-Issue-3044847-by-fgm-_dmemcache_write_debug-uses-und.patch1.34 KB

Suggested patch.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new 0001-Issue-3044847-by-fgm-_dmemcache_write_debug-uses-und.patch2.4 KB

Better patch also fixing the incorrect doc comment on that function and another one, and an incorrect parameter in a function calling it.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue tags: +Needs reroll

Patch does not apply to 7.x-1.x.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Needs work

OTOH... The error message in the log file is a handy way to count how many cache writes you have per request. :-)

sokru’s picture

sokru commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 3044847-dmemcache-write-debug-6-D7.patch2.02 KB

Reroll with minor coding standard adjustments.

jeremy’s picture

jeremy commented
StatusFileSize
new 3044847.patch2.04 KB

Additional cleanup of phpdoc wording

jeremy’s picture

jeremy commented
StatusFileSize
new 3044847-2.patch2.19 KB

During testing, this needed a little more work -- testing with both PECL memcache and PECL memcached.

jeremy’s picture

jeremy commented
StatusFileSize
new 3044847-2b.patch1.88 KB

It would help if I uploaded the correct patch -- trying again.

  • Jeremy committed 47050cb on 7.x-1.x authored by fgm 
    Issue #3044847 by Jeremy, fgm, sokru: _dmemcache_write_debug uses...
jeremy’s picture

jeremy commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.