I replaced $account = \Drupal::getContainer()->get('current_user'); with Current User Service using Dependency Injection Container.

CommentFileSizeAuthor
#2 dependency_injection-3044805-2.patch2.39 KBsergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new dependency_injection-3044805-2.patch2.39 KB
joshua.roberson’s picture

joshua.roberson commented
Status: Needs review » Postponed (maintainer needs more info)

Sergiu, can you add more info on what bug this fixes? Are you getting an error or does something not work with the current features? I need to be able to reproduce the issue to review if the patch fixes it.

If there is no bug, then this should be changed to a feature request and also described as to why it is needed.

joshua.roberson’s picture

joshua.roberson commented
Category: Bug report » Task
Status: Postponed (maintainer needs more info) » Needs review

Ok, I see what you are trying to accomplish with the patch. You are updating the coding standard to Symfony 2's dependency injection. Since nothing is broken and it is just something that needs to be done, I will change this from a "Bug" to a "Task".

I'll try to look over it and test things when I get another chance.

joshua.roberson’s picture

joshua.roberson commented
Status: Needs review » Reviewed & tested by the community

I tested this patch and it didn't break anything.

joshua.roberson’s picture

joshua.roberson commented
Status: Reviewed & tested by the community » Fixed

This has been applied to dev.

joshua.roberson’s picture

joshua.roberson commented
Status: Fixed » Closed (fixed)