Preparing my project for php7.2, PHPCS found this :

$ vendor/bin/phpcs -p web/modules/ --standard=PHPCompatibility --extensions=module/php,inc/php,install/php,php/php --runtime-set testVersion 7.2

FILE: ...ome/dev/projet/web/modules/contrib/salesforce/src/SoapClient.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | WARNING | No PHP code was found in this file and short open tags
   |         | are not allowed by this install of PHP. This file may
   |         | be using short open tags but PHP does not allow them.
----------------------------------------------------------------------
CommentFileSizeAuthor
#2 soapclient_is_empty-3044119-2.patch103 bytespguillard

Comments

pguillard created an issue. See original summary.

pguillard’s picture

pguillard commented
Status: Active » Needs review
StatusFileSize
new soapclient_is_empty-3044119-2.patch103 bytes

Here is the patch

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs review » Fixed

Weird that lint never flagged that for me.
Thanks for the patch

pguillard’s picture

pguillard commented

What a reactivity ! thanks.

aaronbauman’s picture

aaronbauman
he/him
commented

Sure thing.
You caught me in the middle of gearing up for a new release, so i'm trying to stay on top of the issue queue

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.