[D8] Image Base64 Formatter

Hi @i.vuchkov

See the following:

There is a git tag that has the same name as the branch 8.x-1.x. Make sure to remove this tag to avoid confusion.

Can you please remove the 8.x-1.x tag from the 8.x-1.x branch, so that we can run the PAReview report against your branch?

Thanks!

I am closing this application due to lack of replies. Please see comment #3 for what needs to be fixed.

• What follows is a quick review of the project; it doesn't mean to be complete
• For every point, I didn't make a complete list of where the code should be fixed, but an example of what is wrong in the code
• Not all the points are application stoppers; some of them describe changes that would be preferable to make

1. The code should not use entity_load() or t() when dependency injection is available, for example inside plugin classes
2. The code doesn't follow the Drupal coding standards in many points

Thanks for your contribution!

* Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
* Move all code files to the root folder of the project. No need to create a nested image_base64_formatter folder again.
* template_preprocess_image_base64_formatter(): empty function, should be removed.
* ImageBase64Formatter::viewElements(): do not build markup here, return a render array and use a twig template instead that other people can easily override.

Otherwise looks good to me, did not see any security issues.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Already Approved

It appears that you have successfully completed the application process with this application, and been granted the security advisory coverage permission:

With this in mind, I have marked your application as 'fixed'. If this is incorrect, and you do not yet have the ability to opt into security advisory coverage, then please feel free to re-open this application.

Maybe you did not edit your project yet to opt into security advisory coverage?