This module should have a composer.json module to stipulate contrib module dependencies, specifically geolocation. This will then install geolocation and prevent errors on install due to missing dependencies.

E.g.

Configuration objects provided by taxonomy_placehave unmet dependencies: core.entity_form_display.taxonomy_term.place.default (geolocation)

CommentFileSizeAuthor
#9 3043584-add-composer.json_.patch528 byteskarens
#3 missing_composer_json_file_3043584_3.patch503 bytesbrooke_heaton
#2 missing_composer_json_file_3043584_2.patch751 bytesbrooke_heaton

Comments

brooke_heaton created an issue. See original summary.

brooke_heaton’s picture

brooke_heaton commented
StatusFileSize
new missing_composer_json_file_3043584_2.patch751 bytes

Add patch for composer.json file stipulating drupal/address and drupal/geolocation module dependencies.

brooke_heaton’s picture

brooke_heaton commented
StatusFileSize
new missing_composer_json_file_3043584_3.patch503 bytes

Corrected issues with the patch. Updated #3.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Title: Missing composer.json file » Missing geolocation dependency

This module depends on geolocation module via config but doesn't add it to list of dependencies in taxonomy_place.info.yml. See http://cgit.drupalcode.org/taxonomy_place/tree/config/install/core.entit... for unmet dependency.

Also - adding composer.json is not really required if dependency will be added to taxonomy_place.info.yml.

brooke_heaton’s picture

brooke_heaton commented
Status: Active » Needs review
tormi’s picture

tormi
Primary language Estonian
Location Tallinn
commented
Status: Needs review » Needs work

@zaporylie gave a review at #4, back to Needs work.

brooke_heaton’s picture

brooke_heaton commented

Unmet dependencies, including geolocation, are addressed in #3030130: Errors in dependencies. Should this issue address the .info file as well?

brooke_heaton’s picture

brooke_heaton commented

Regarding the need or lack of a need for a composer.json for other contrib modules, I was following the best practices outlined here: https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...

Thus I assumed it was best practice to explicitly declare the dependency on drupal/geolocation.

karens’s picture

karens commented
Status: Needs work » Needs review
StatusFileSize
new 3043584-add-composer.json_.patch528 bytes

This is part of the fix, there is another issue about .info file. I had to re-roll this it wouldn't apply.

  • KarenS committed 4727f86 on 8.x-1.x 
    Issue #3043584 by brooke_heaton, KarenS, zaporylie, tormi: Missing...
karens’s picture

karens commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.