Problem/Motivation

Add 'Where' statements to query (in a relation) only if the relation is required.

Proposed resolution

See Patch.

Remaining tasks

Review patch.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#8 recently_read-views_relationship_plugin-3043512-8-D8.patch0 bytesnikita_tt
#4 recently_read-views_relationship_plugin-3043512-4-D8.patch3.38 KBnikita_tt
#2 recently_read-3043512-1.patch1.25 KBtomhollevoet

Comments

tomhollevoet created an issue. See original summary.

tomhollevoet’s picture

tomhollevoet commented
StatusFileSize
new recently_read-3043512-1.patch1.25 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Doing a query with the where for non-required items does lead to the wrong results. This fixes that. Looks great.

nikita_tt’s picture

nikita_tt
Primary language Ukrainian
commented
StatusFileSize
new recently_read-views_relationship_plugin-3043512-4-D8.patch3.38 KB

Here is a patch with another way to resolve the issue.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Reviewed & tested by the community » Fixed

Commited patch #2, with some additional fixes, thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

nikita_tt’s picture

nikita_tt
Primary language Ukrainian
commented
StatusFileSize
new recently_read-views_relationship_plugin-3043512-8-D8.patch0 bytes

See here https://www.drupal.org/project/recently_read/issues/3194215

nikita_tt’s picture

nikita_tt
Primary language Ukrainian
commented