On PHP 7.2, Easy Breadcrumb will trigger a warning if the breadcrumb is empty:
Warning: count(): Parameter must be an array or an object that implements Countable in template_preprocess_easy_breadcrumb()(line 158 of [...]/easy_breadcrumb.module).
This is because PHP 7.2 gives a warning when attempting to count non-countable objects:
http://php.net/manual/en/migration72.incompatible.php#migration72.incomp...
Reproduction steps:
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | easy-breadcrumb-php72-count-warning-3043400-5.patch | 774 bytes | tatarbj |
| #3 | easy-breadcrumb-php72-count-warning-3043400-3.patch | 777 bytes | .tom |
Comments
Comment #2
tatarbjThanks @.tom,
let me get back to you with a patch to resolve it!
Bests,
Balazs.
Comment #3
.tom commented@tatarbj
I already wrote a patch, I was just getting the naming right. Please check!
Cheers!
Comment #4
.tom commentedComment #5
tatarbjThat's exactly what I'm thinking about - should we check the availability there (isset() seems a better approach) or initialize it before the foreach().
Could you just confirm the isset() also resolves the warning on your end (having issues with setting up php7.2 at the moment).
Comment #6
tatarbjJust in case, I've queued both of the patches for PHP 7.2 & MySQL 5.5 to see the tests.
Comment #7
.tom commentedYes, isset() works fine for me. I originally wrote isset(), but thought that is_array() might be (marginally) better since isset() still leaves room for non-countable values. But I don't know if this could ever actually occur.
Comment #9
tatarbjThanks @.tom,
it's committed and will be in the new release when other issues are done too.
Bests,
Balazs
Comment #10
tatarbj