Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/role_delegation f0ea52faf87b8683de43a6149e3df704dbb3c995
source : http://cgit.drupalcode.org/role_delegation 


 ------ --------------------------------------------------- 
  Line   src/Form/RoleDelegationSettingsForm.php            
 ------ --------------------------------------------------- 
  90     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ------------------------------------------------------------------ 
  Line   tests/src/Kernel/AccessTest.php                                   
 ------ ------------------------------------------------------------------ 
  15     Usage of deprecated trait Drupal\simpletest\UserCreationTrait in  
         class Drupal\Tests
ole_delegation\Kernel\AccessTest.             
 ------ ------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------ 
  Line   tests/src/Kernel/DelegatableRolesTest.php                         
 ------ ------------------------------------------------------------------ 
  16     Usage of deprecated trait Drupal\simpletest\UserCreationTrait in  
         class Drupal\Tests
ole_delegation\Kernel\DelegatableRolesTest.   
 ------ ------------------------------------------------------------------ 

 [ERROR] Found 3 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 drupal_9_deprecated_code-3042838-4.patch3.12 KBsergiu stici
#2 drupal_9_deprecated_code-3042838-2.patch2.79 KBsergiu stici

Comments

mcdwayne created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042838-2.patch2.79 KB

Here is the patch, please review.

Status: Needs review » Needs work

The last submitted patch, 2: drupal_9_deprecated_code-3042838-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

sergiu stici’s picture

sergiu stici commented
Status: Needs work » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042838-4.patch3.12 KB

Corrected codesniffer.

Status: Needs review » Needs work

The last submitted patch, 4: drupal_9_deprecated_code-3042838-4.patch, failed testing. View results

  • JeroenT committed e32bd7e on 8.x-1.x 
    Issue #3042838 by Sergiu Stici: Drupal 9 Deprecated Code Report
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Fixed

Committed and pushed to 8.x-1.x. Thanks!

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.