Drupal 9 Deprecated Code Report [#3042792]

Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/fontyourface 4e7ac385ec74ca1506df727039607a369c02e9cc
source : http://cgit.drupalcode.org/fontyourface


 ------ ------------------------------------------------------------ 
  Line   fontyourface.module                                         
 ------ ------------------------------------------------------------ 
  169    Call to deprecated method l() of class Drupal.              
  213    Call to deprecated method l() of class Drupal.              
  362    Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ --------------------------------------------------- 
  Line   modules/adobe_edge_fonts/adobe_edge_fonts.module   
 ------ --------------------------------------------------- 
  28     Call to deprecated function drupal_set_message().  
  75     Call to deprecated function drupal_set_message().  
  118    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   modules/fontscom_api/fontscom_api.module           
 ------ --------------------------------------------------- 
  40     Call to deprecated function drupal_set_message().  
  125    Call to deprecated function drupal_set_message().  
  256    Call to deprecated function drupal_set_message().  
  260    Call to deprecated function drupal_set_message().  
  304    Call to deprecated function drupal_set_message().  
  368    Call to deprecated function drupal_set_message().  
  399    Call to deprecated function drupal_set_message().  
  427    Call to deprecated function drupal_set_message().  
  449    Call to deprecated function drupal_set_message().  
  483    Call to deprecated function drupal_set_message().  
  508    Call to deprecated function drupal_set_message().  
  527    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   modules/fontsquirrel_api/fontsquirrel_api.module   
 ------ --------------------------------------------------- 
  30     Call to deprecated function drupal_set_message().  
  47     Call to deprecated function drupal_realpath().     
  52     Call to deprecated function drupal_realpath().     
  205    Call to deprecated function drupal_set_message().  
  223    Call to deprecated function drupal_set_message().  
  246    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   modules/google_fonts_api/google_fonts_api.module   
 ------ --------------------------------------------------- 
  28     Call to deprecated function drupal_set_message().  
  132    Call to deprecated function drupal_set_message().  
  155    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ------------------------------------------------------------ 
  Line   modules/local_fonts/local_fonts.module                      
 ------ ------------------------------------------------------------ 
  84     Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------------------------ 
  Line   modules/local_fonts/src/Form/LocalFontConfigEntityDeleteForm.php  
 ------ ------------------------------------------------------------------ 
  41     Call to deprecated function drupal_set_message().                 
 ------ ------------------------------------------------------------------ 

 ------ ------------------------------------------------------------ 
  Line   modules/local_fonts/src/Form/LocalFontConfigEntityForm.php  
 ------ ------------------------------------------------------------ 
  138    Call to deprecated function drupal_set_message().           
  144    Call to deprecated function drupal_set_message().           
  148    Call to deprecated method urlInfo() of class                
         Drupal\Core\Entity\EntityInterface.                         
 ------ ------------------------------------------------------------ 

 ------ --------------------------------------------------- 
  Line   modules/typekit_api/typekit_api.module             
 ------ --------------------------------------------------- 
  32     Call to deprecated function drupal_set_message().  
  61     Call to deprecated function drupal_set_message().  
  102    Call to deprecated function drupal_set_message().  
  133    Call to deprecated function drupal_set_message().  
  136    Call to deprecated function drupal_set_message().  
  156    Call to deprecated function drupal_set_message().  
  180    Call to deprecated function drupal_set_message().  
  206    Call to deprecated function drupal_set_message().  
  249    Call to deprecated method strtolower() of class    
         Drupal\Component\Utility\Unicode.                  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Controller/FontYourFaceController.php          
 ------ --------------------------------------------------- 
  26     Call to deprecated method l() of class Drupal.     
  32     Call to deprecated function drupal_set_message().  
  45     Call to deprecated function drupal_set_message().  
  61     Call to deprecated method l() of class Drupal.     
  67     Call to deprecated function drupal_set_message().  
  80     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ------------------------------------------------------------ 
  Line   src/Entity/Font.php                                         
 ------ ------------------------------------------------------------ 
  182    Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------------------ 
  Line   src/Entity/FontDisplay.php                                  
 ------ ------------------------------------------------------------ 
  175    Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------------------------ 
  Line   src/FontListBuilder.php                                           
 ------ ------------------------------------------------------------------ 
  16     Usage of deprecated trait Drupal\Core\Routing\LinkGeneratorTrait  
         in class Drupalontyourface\FontListBuilder.                     
  33     Call to deprecated method l() of class                            
         Drupalontyourface\FontListBuilder.                              
  35     Call to deprecated method urlInfo() of class                      
         Drupal\Core\Entity\EntityInterface.                               
  56     Call to deprecated method urlInfo() of class                      
         Drupal\Core\Entity\EntityInterface.                               
 ------ ------------------------------------------------------------------ 

 ------ --------------------------------------------------- 
  Line   src/Form/FontDisplayDeleteForm.php                 
 ------ --------------------------------------------------- 
  41     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/FontDisplayForm.php                       
 ------ --------------------------------------------------- 
  47     Call to deprecated function drupal_set_message().  
  174    Call to deprecated function drupal_set_message().  
  180    Call to deprecated function drupal_set_message().  
  186    Call to deprecated method urlInfo() of class       
         Drupal\Core\Entity\EntityInterface.                
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/FontForm.php                              
 ------ --------------------------------------------------- 
  35     Call to deprecated function drupal_set_message().  
  41     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/FontSettingsForm.php                      
 ------ --------------------------------------------------- 
  159    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ---------------------------------------------------- 
  Line   tests/websafe_fonts_test/websafe_fonts_test.module  
 ------ ---------------------------------------------------- 
  57     Call to deprecated function drupal_set_message().   
 ------ ---------------------------------------------------- 

 [ERROR] Found 62 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#22	3042792-22.patch	17.17 KB	neslee canil pinto
#20	3042792-20.patch	15.09 KB	suresh prabhu parkala
#19	3042792-19.patch	15.07 KB	suresh prabhu parkala
#16	3042792-16.patch	15.01 KB	suresh prabhu parkala
#10	interdiff_8_9.diff	3.31 KB	nikolas.tatianenko
#10	fontyourface-3042792-9.patch	25.14 KB	nikolas.tatianenko
#9	fontyourface-3042792-8.patch	21.59 KB	douggreen
#8	fontyourface-3042792-7.patch	21.58 KB	douggreen
#5	fontyourface-3082934-5.patch	17.5 KB	douggreen
#2	drupal_9_deprecated_code-3042792-2.patch	30.38 KB	sergiu stici

Comments

Comment #1

23 March 2019 at 23:20

mcdwayne created an issue. See original summary.

Status	File	Size
new	drupal_9_deprecated_code-3042792-2.patch	30.38 KB

Comment #3

btmash commented 22 May 2019 at 03:41

Status:

Needs review

» Postponed

Sorry for not responding to this sooner. I'm finally getting back to maintaining this module.

To be really frank, I'm going to postpone this. I appreciate the patch but removing the deprecated code means its not going to work with older versions of Drupal 8.x. There will be a 9.x branch where all the deprecated code will get removed.

Comment #4

ccjjmartin commented 10 April 2020 at 20:00

Status:

Postponed

» Closed (outdated)

@sergiu-stici I would like to apologize to you from the whole Drupal community and say that your hard work here was very clearly overlooked and a patch that clearly had a lot of good work in it was not committed. This module could have been ready a year ago but now others had to repeat your work in other issues.

Looking at the other open issues of this module and recent commits of this project this issue is now outdated and will never be committed. I am going to mark it as closed (outdated). I hope this does not dissuade you from future contributions.

cc: @BTMash

Comment #5

douggreen commented 28 April 2020 at 13:27

Status	File	Size
new	fontyourface-3082934-5.patch	17.5 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	drupal_9_deprecated_code-3042792-2.patch	30.38 KB

I need a clean patch to prepare For Drupal 9 and couldn't find al the issues that @ccjmartin mentioned above. I only found [#3082934. The attached patch is my first pass based on drupal-check.

Comment #6

douggreen commented 28 April 2020 at 13:31

Status:

Closed (outdated)

» Needs review

Reopening in the hopes that the module maintainer will reconsider. The composer.json changes make it so that this module would require Drupal 8.7.7 or higher. Sites should be running that version because anything below it is not supported with security updates.

Comment #7

28 April 2020 at 13:34

Status:

Needs review

» Needs work

The last submitted patch, 5: fontyourface-3082934-5.patch, failed testing. View results

Comment #8

douggreen commented 28 April 2020 at 15:05

Status	File	Size
new	fontyourface-3042792-7.patch	21.58 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	fontyourface-3082934-5.patch	17.5 KB

Updated patch includes composer and core_version_requirement updates.

Comment #9

douggreen commented 28 April 2020 at 17:47

Status	File	Size
new	fontyourface-3042792-8.patch	21.59 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	fontyourface-3042792-7.patch	21.58 KB

Updated patch fixes core_version_requirment to 8.7.7 instead of 8.7.

Comment #10

nikolas.tatianenko commented 23 May 2020 at 14:22

Issue tags:

+Drupal 9 porting weekend, +epam-contrib

Status	File	Size
new	fontyourface-3042792-9.patch	25.14 KB
new	interdiff_8_9.diff	3.31 KB

Additional improvements. No known errors
Rector 0.8.x-dev@8896f0a
Config file: rector.yml

138/138 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] Rector is done!

Comment #11

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

commented 11 June 2020 at 08:32

@nikolas.tatianenko - any plans to push this code to dev?
I'd like to test it for dgo.to/openy readiness asap
Thank you

Comment #12

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

commented 15 June 2020 at 09:02

Status:

Needs work

» Reviewed & tested by the community

Comment #13

15 June 2020 at 09:06

The last submitted patch, 9: fontyourface-3042792-8.patch, failed testing. View results

Comment #14

neslee canil pinto

he/him

English

commented 8 August 2020 at 15:39

Status:

Reviewed & tested by the community

» Needs work

Comment #15

suresh prabhu parkala commented 10 August 2020 at 05:40

Assigned:

Unassigned

» suresh prabhu parkala

Comment #16

suresh prabhu parkala commented 10 August 2020 at 06:29

Status:

Needs work

» Needs review

Status	File	Size
new	3042792-16.patch	15.01 KB

Re-rolled patch. Please review!

Comment #17

10 August 2020 at 06:33

Status:

Needs review

» Needs work

The last submitted patch, 16: 3042792-16.patch, failed testing. View results

Comment #18

neslee canil pinto

he/him

English

commented 11 August 2020 at 16:27

Issue tags:

+Needs reroll

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 15371  100 15371    0     0  12103      0  0:00:01  0:00:01 --:--:-- 12103
error: patch failed: fontyourface.module:405
error: fontyourface.module: patch does not apply
error: patch failed: modules/fontscom_api/fontscom_api.module:158
error: modules/fontscom_api/fontscom_api.module: patch does not apply
error: patch failed: modules/local_fonts/local_fonts.module:102
error: modules/local_fonts/local_fonts.module: patch does not apply

Comment #19

suresh prabhu parkala commented 12 August 2020 at 04:58

Status:

Needs work

» Needs review

Status	File	Size
new	3042792-19.patch	15.07 KB

Re-rolled patch please review!

Comment #20

suresh prabhu parkala commented 12 August 2020 at 05:21

Status	File	Size
new	3042792-20.patch	15.09 KB

Please review!

Comment #21

12 August 2020 at 05:28

Status:

Needs review

» Needs work

The last submitted patch, 20: 3042792-20.patch, failed testing. View results

Comment #22

neslee canil pinto

he/him

English

commented 12 August 2020 at 19:27

Status	File	Size
new	3042792-22.patch	17.17 KB

Fixed the tests which are failing

Comment #23

12 August 2020 at 19:27

Neslee Canil Pinto committed 440bd42 on 8.x-3.x

Issue #3042792 by douggreen, Suresh Prabhu Parkala, nikolas.tatianenko,...

Comment #24

neslee canil pinto

he/him

English

commented 12 August 2020 at 19:28

Status:

Needs work

» Fixed

Comment #25

26 August 2020 at 19:29

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Drupal 9 Deprecated Code Report

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

Comment #25

News items

Our community

Documentation

Drupal code base

Governance of community