Drupal 9 Deprecated Code Report [#3042763]

Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/file_entity bedef1b99cc0d4cafc3f3aa73e2c167e0851c993
source : http://cgit.drupalcode.org/file_entity


 

 ------ ------------------------------------------------------------------- 
  Line   file_entity.module                                                 
 ------ ------------------------------------------------------------------- 
  236    Call to deprecated method url() of class                           
         Drupal\Core\Entity\EntityInterface.                                
  296    Call to deprecated method entityManager() of class Drupal.         
  361    Calls to function fnmatch should not exist.                        
  361    Calls to function fnmatch should not exist.                        
  466    Call to deprecated function entity_load_multiple_by_properties().  
 ------ ------------------------------------------------------------------- 

 ------ ------------------------------------------------- 
  Line   file_entity.tokens.inc                           
 ------ ------------------------------------------------- 
  87     Call to deprecated method checkPlain() of class  
         Drupal\Component\Utility\SafeMarkup.             
  87     Call to method checkPlain() of deprecated class  
         Drupal\Component\Utility\SafeMarkup.             
  114    Call to deprecated method checkPlain() of class  
         Drupal\Component\Utility\SafeMarkup.             
  114    Call to method checkPlain() of deprecated class  
         Drupal\Component\Utility\SafeMarkup.             
  123    Call to deprecated function db_select().         
 ------ ------------------------------------------------- 

 ------ ---------------------------------------------------- 
  Line   src/Controller/FileController.php                   
 ------ ---------------------------------------------------- 
  63     Call to deprecated function drupal_basename().      
  97     Call to deprecated method entityManager() of class  
         Drupal\Core\Controller\ControllerBase.              
 ------ ---------------------------------------------------- 

 ------ ---------------------------------------------------- 
  Line   src/Entity/FileEntity.php                           
 ------ ---------------------------------------------------- 
  42     Call to deprecated function db_query().             
  203    Call to deprecated function db_delete().            
  207    Call to deprecated function db_insert().            
  300    Call to deprecated function db_delete().            
  397    Call to deprecated function file_uri_scheme().      
  410    Call to deprecated function file_uri_scheme().      
  434    Call to deprecated function file_uri_scheme().      
  518    Call to deprecated method entityManager() of class  
         Drupal\Core\Entity\Entity.                          
 ------ ---------------------------------------------------- 

 ------ ------------------------------------------------------------ 
  Line   src/Entity/FileEntityViewBuilder.php                        
 ------ ------------------------------------------------------------ 
  30     Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------ 
  Line   src/FileEntityAccessControlHandler.php          
 ------ ------------------------------------------------ 
  53     Call to deprecated function file_uri_scheme().  
 ------ ------------------------------------------------ 

 ------ ----------------------------------------------- 
  Line   src/FileTypeListBuilder.php                    
 ------ ----------------------------------------------- 
  35     Call to deprecated method getLabel() of class  
         Drupal\Core\Entity\EntityListBuilder.          
 ------ ----------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/FileAddArchiveForm.php                    
 ------ --------------------------------------------------- 
  97     Call to deprecated function drupal_unlink().       
  100    Call to deprecated function drupal_set_message().  
  102    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ------------------------------------------------------------ 
  Line   src/Form/FileAddForm.php                                    
 ------ ------------------------------------------------------------ 
  92     Call to deprecated function drupal_render().                
  184    Call to deprecated method entityManager() of class Drupal.  
  204    Call to deprecated method checkPlain() of class             
         Drupal\Component\Utility\SafeMarkup.                        
  204    Call to method checkPlain() of deprecated class             
         Drupal\Component\Utility\SafeMarkup.                        
  336    Call to deprecated function file_uri_scheme().              
  391    Call to deprecated function file_uri_scheme().              
  410    Call to deprecated function drupal_set_message().           
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------- 
  Line   src/Form/FileDeleteMultipleForm.php              
 ------ ------------------------------------------------- 
  110    Call to deprecated method checkPlain() of class  
         Drupal\Component\Utility\SafeMarkup.             
  110    Call to method checkPlain() of deprecated class  
         Drupal\Component\Utility\SafeMarkup.             
 ------ ------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/FileEditForm.php                          
 ------ --------------------------------------------------- 
  68     Call to deprecated function drupal_render().       
  86     Call to deprecated function drupal_set_message().  
  89     Call to deprecated function drupal_set_message().  
  94     Call to deprecated method urlInfo() of class       
         Drupal\Core\Entity\EntityInterface.                
  99     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/FileSettingsForm.php                      
 ------ --------------------------------------------------- 
  137    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/FileTypeDisableForm.php                   
 ------ --------------------------------------------------- 
  39     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/FileTypeEnableForm.php                    
 ------ --------------------------------------------------- 
  39     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/FileTypeForm.php                          
 ------ --------------------------------------------------- 
  112    Call to deprecated function drupal_set_message().  
  115    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ----------------------------------------------- 
  Line   src/Normalizer/FileEntityNormalizer.php        
 ------ ----------------------------------------------- 
  43     Call to deprecated function drupal_dirname().  
  49     Call to deprecated method format() of class    
         Drupal\Component\Utility\SafeMarkup.           
  49     Call to method format() of deprecated class    
         Drupal\Component\Utility\SafeMarkup.           
 ------ ----------------------------------------------- 

 ------ ------------------------------------------------------- 
  Line   src/Plugin/views/field/LinkDelete.php                  
 ------ ------------------------------------------------------- 
  34     Call to deprecated function drupal_get_destination().  
 ------ ------------------------------------------------------- 

 ------ ------------------------------------------------------- 
  Line   src/Plugin/views/field/LinkEdit.php                    
 ------ ------------------------------------------------------- 
  34     Call to deprecated function drupal_get_destination().  
 ------ ------------------------------------------------------- 

 ------ ---------------------------------------- 
  Line   src/Plugin/views/filter/SchemeType.php  
 ------ ---------------------------------------- 
  48     Call to deprecated function db_like().  
 ------ ---------------------------------------- 

 ------ -------------------------------------------------- 
  Line   src/Tests/FileEntityAccessTest.php                
 ------ -------------------------------------------------- 
  205    Call to deprecated method getUsername() of class  
         Drupal\user\Entity\User.                          
  217    Call to deprecated function format_string().      
  219    Call to deprecated function format_string().      
 ------ -------------------------------------------------- 

 ------ ------------------------------------------------------------ 
  Line   src/Tests/FileEntityAdminTest.php                           
 ------ ------------------------------------------------------------ 
  178    Call to deprecated method url() of class                    
         Drupalile_entity\Entity\FileEntity.                       
  180    Call to deprecated method url() of class                    
         Drupalile_entity\Entity\FileEntity.                       
  182    Call to deprecated method url() of class                    
         Drupalile_entity\Entity\FileEntity.                       
  186    Call to deprecated method url() of class                    
         Drupalile_entity\Entity\FileEntity.                       
  187    Call to deprecated method url() of class                    
         Drupalile_entity\Entity\FileEntity.                       
  188    Call to deprecated method url() of class                    
         Drupalile_entity\Entity\FileEntity.                       
  263    Call to deprecated method entityManager() of class Drupal.  
  277    Call to deprecated method entityManager() of class Drupal.  
  295    Call to deprecated method entityManager() of class Drupal.  
  346    Call to deprecated method entityManager() of class Drupal.  
  347    Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ------------------------------------------------------------------ 
  Line   src/Tests/FileEntityCacheTagsTest.php                             
 ------ ------------------------------------------------------------------ 
  20     Usage of deprecated trait                                         
         Drupal\system\Tests\Cache\AssertPageCacheContextsAndTagsTrait in  
         class Drupalile_entity\Tests\FileEntityCacheTagsTest.           
  154    Call to deprecated method format() of class                       
         Drupal\Component\Utility\SafeMarkup.                              
  154    Call to method format() of deprecated class                       
         Drupal\Component\Utility\SafeMarkup.                              
 ------ ------------------------------------------------------------------ 

 ------ ------------------------------------------------ 
  Line   src/Tests/FileEntityCreationTest.php            
 ------ ------------------------------------------------ 
  49     Call to deprecated function drupal_realpath().  
  71     Call to deprecated function drupal_realpath().  
  109    Call to deprecated function drupal_realpath().  
 ------ ------------------------------------------------ 

 ------ ------------------------------------------------------------ 
  Line   src/Tests/FileEntityEditTest.php                            
 ------ ------------------------------------------------------------ 
  39     Call to deprecated function drupal_realpath().              
  51     Call to deprecated method url() of class                    
         Drupal\Core\Entity\EntityInterface.                         
  84     Call to deprecated function drupal_realpath().              
  102    Call to deprecated method entityManager() of class Drupal.  
  111    Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ---------------------------------------------------- 
  Line   src/Tests/FileEntityFileTypeClassificationTest.php  
 ------ ---------------------------------------------------- 
  32     Call to deprecated function db_select().            
 ------ ---------------------------------------------------- 

 ------ ------------------------------------------------- 
  Line   src/Tests/FileEntityPathautoTest.php             
 ------ ------------------------------------------------- 
  29     Call to deprecated method strtolower() of class  
         Drupal\Component\Utility\Unicode.                
  38     Call to deprecated method urlInfo() of class     
         Drupal\Core\Entity\Entity.                       
 ------ ------------------------------------------------- 

 ------ ------------------------------------------------ 
  Line   src/Tests/FileEntityReplaceTest.php             
 ------ ------------------------------------------------ 
  48     Call to deprecated function drupal_realpath().  
  65     Call to deprecated function drupal_realpath().  
  76     Call to deprecated function drupal_realpath().  
  86     Call to deprecated function drupal_basename().  
 ------ ------------------------------------------------ 

 ------ --------------------------------------------------------------- 
  Line   src/Tests/FileEntityServicesTest.php                           
 ------ --------------------------------------------------------------- 
  18     Class Drupalile_entity\Tests\FileEntityServicesTest extends  
         deprecated class Drupal
est\Tests\RESTTestBase.               
  79     Call to deprecated method urlInfo() of class                   
         Drupal\Core\Entity\Entity.                                     
  85     Call to deprecated method urlInfo() of class                   
         Drupal\Core\Entity\Entity.                                     
  89     Call to deprecated method urlInfo() of class                   
         Drupal\Core\Entity\Entity.                                     
 ------ --------------------------------------------------------------- 

 ------ ------------------------------------------------------------------- 
  Line   src/Tests/FileEntityTestBase.php                                   
 ------ ------------------------------------------------------------------- 
  158    Call to deprecated function entity_load_multiple_by_properties().  
 ------ ------------------------------------------------------------------- 

 ------ -------------------------------------------------------- 
  Line   src/Tests/FileEntityTypeTest.php                        
 ------ -------------------------------------------------------- 
  59     Call to deprecated method strtolower() of class         
         Drupal\Component\Utility\Unicode.                       
  72     Call to deprecated function entity_get_form_display().  
  86     Call to deprecated function drupal_realpath().          
  123    Call to deprecated method strtolower() of class         
         Drupal\Component\Utility\Unicode.                       
  136    Call to deprecated function entity_get_form_display().  
  149    Call to deprecated function drupal_realpath().          
 ------ -------------------------------------------------------- 

 ------ ------------------------------------------------------------ 
  Line   src/Tests/FileEntityUnitTest.php                            
 ------ ------------------------------------------------------------ 
  81     Call to deprecated method entityManager() of class Drupal.  
  82     Call to deprecated function file_load_multiple().           
  102    Call to deprecated function file_load_multiple().           
  132    Call to deprecated method entityManager() of class Drupal.  
  148    Call to deprecated function db_query().                     
 ------ ------------------------------------------------------------ 

 ------ -------------------------------------------------- 
  Line   tests/src/Kernel/FileEntityNormalizerTest.php     
 ------ -------------------------------------------------- 
  110    Call to deprecated method assertEqual() of class  
         Drupal\KernelTests\KernelTestBase.                
  153    Call to deprecated method assertEqual() of class  
         Drupal\KernelTests\KernelTestBase.                
  155    Call to deprecated method assertEqual() of class  
         Drupal\KernelTests\KernelTestBase.                
  156    Call to deprecated method assertEqual() of class  
         Drupal\KernelTests\KernelTestBase.                
  211    Call to deprecated method assertEqual() of class  
         Drupal\KernelTests\KernelTestBase.                
 ------ -------------------------------------------------- 

 ------ -------------------------------------------------------------------- 
  Line   views/views_handler_field_file_rendered.inc                         
 ------ -------------------------------------------------------------------- 
         Class views_handler_field_file_rendered was not found while trying  
         to analyse it - autoloading is probably not configured properly.    
 ------ -------------------------------------------------------------------- 

 ------ --------------------------------------------------------------- 
  Line   views/views_plugin_row_file_rss.inc                            
 ------ --------------------------------------------------------------- 
         Class views_plugin_row_file_rss was not found while trying to  
         analyse it - autoloading is probably not configured properly.  
 ------ --------------------------------------------------------------- 

 [ERROR] Found 106 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#31	file_entity-3042763-31.patch	5.17 KB	sharif.elshobkshy
#30	file_entity-3042763-30.patch	101.13 KB	luca_loguercio
#26	drupal_9_deprecated_code-3042763-26-interdiff.txt	864 bytes	berdir
#26	drupal_9_deprecated_code-3042763-26.patch	105.86 KB	berdir
#25	drupal_9_deprecated_code-3042763-25-interdiff.txt	2.02 KB	berdir
#25	drupal_9_deprecated_code-3042763-25.patch	105.02 KB	berdir
#23	drupal_9_deprecated_code-3042763-23-interdiff.txt	46.61 KB	berdir
#23	drupal_9_deprecated_code-3042763-23.patch	105.1 KB	berdir
#21	drupal_9_deprecated_code-3042763-21.patch	75.83 KB	primsi
#21	drupal_9_deprecated_code-3042763-21.interdiff.txt	28.54 KB	primsi
#20	drupal_9_deprecated_code-3042763-19.patch	111.63 KB	primsi
#20	drupal_9_deprecated_code-3042763-19.interdiff.txt	78.8 KB	primsi
#19	drupal_9_deprecated_code-3042763-19.patch	111.63 KB	primsi
#16	interdiff-12_16.txt	4.33 KB	anmolgoyal74
#16	drupal_9_deprecated_code-3042763-16.patch	52.5 KB	anmolgoyal74
#12	drupal_9_deprecated_code-3042763-12.patch	52.55 KB	joseph.olstad
#2	drupal_9_deprecated_code-3042763-2.patch	52.58 KB	sergiu stici

Comments

Comment #1

23 March 2019 at 22:50

mcdwayne created an issue. See original summary.

Status	File	Size
new	drupal_9_deprecated_code-3042763-2.patch	52.58 KB

Comment #3

23 April 2019 at 20:07

joseph.olstad committed 52ddf35 on 9.x-2.x authored by Sergiu Stici

Issue #3042763 by Sergiu Stici: Drupal 9 Deprecated Code Report

Comment #4

joseph.olstad

French

commented 23 April 2019 at 20:10

Hi Sergiu, great work on this, not sure if it'll pass tests though.

For now I parked this in a new branch called 9.x-2.x

Comment #5

berdir

German

Switzerland

commented 30 April 2019 at 21:09

We don't know yet how 9.x versions will look like exactly, but changes are that there will *not* be 9.x branches, deprecations are meant to be committed to 8.x, but there's no urgency to that and shouldn't be done while tests are as broken as they are now.

Comment #6

joseph.olstad

French

commented 1 May 2019 at 01:34

I retriggered tests of this patch on the 8.x branch, it might (probably) need(s) a reroll?

Comment #7

16 June 2019 at 15:31

joseph.olstad committed 52ddf35 on 8.x-2.x authored by Sergiu Stici

Issue #3042763 by Sergiu Stici: Drupal 9 Deprecated Code Report

Comment #8

joseph.olstad

French

commented 16 June 2019 at 15:43

Status:

Needs review

» Active

I merged this into the 8.x branch

however it seems there was a fatal error, I will try revert

Comment #9

joseph.olstad

French

commented 16 June 2019 at 15:43

might be testbot issue, but...

Comment #10

16 June 2019 at 15:45

joseph.olstad committed c5a2d80 on 8.x-2.x authored by Sergiu Stici

revert (due to testbot failure) Issue #3042763 by Sergiu Stici, joseph....

Comment #11

joseph.olstad

French

commented 16 June 2019 at 15:52

retriggering tests on patch

Comment #12

joseph.olstad

French

commented 16 June 2019 at 16:08

Status	File	Size
new	drupal_9_deprecated_code-3042763-12.patch	52.55 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	drupal_9_deprecated_code-3042763-2.patch	52.58 KB

not sure why the patch isn't applying, it applies in my dev

Comment #13

joseph.olstad

French

commented 16 June 2019 at 16:28

head has 3 fails

Comment #14

berdir

German

Switzerland

commented 10 July 2019 at 21:52

Status:

Active

» Needs work

+++ b/file_entity.tokens.inc
@@ -84,7 +84,7 @@ function file_entity_tokens($type, $tokens, array $data, array $options, Bubblea
           if ($file_type = FileType::load($file->bundle())) {
             $bubbleable_metadata->addCacheableDependency($file_type);
-            $replacements[$original] = $sanitize ? SafeMarkup::checkPlain($file_type->label()) : $file_type->label();
+            $replacements[$original] = $sanitize ? Html::escape($file_type->label()) : $file_type->label();

the concept of sanitizing tokens has been removed long ago, this option doesn't exist anymore and doesn't need to be considered.

Comment #15

joseph.olstad

French

commented 30 July 2019 at 03:58

ok so remove the sanitization then? reroll the patch.
Sounds easy enough, any takers?

Comment #16

anmolgoyal74 commented 12 December 2019 at 18:09

Status:

Needs work

» Needs review

Status	File	Size
new	drupal_9_deprecated_code-3042763-16.patch	52.5 KB
new	interdiff-12_16.txt	4.33 KB

Ro-rolled and removed token sanitizing.

Comment #17

jenlampton

she / her

commented 11 February 2020 at 00:08

I believe that if you add drupal 9 as an option to the composer.json file in this project you can get a nice little Compatible with Drupal 9 badge in the Project information section on the module page.

Screenshot of the Project information section with Compatible with Drupal 9 highlighted

Below is a code sample from a module that has the badge.

"require": {
        "php": "^7.1",
       "drupal/core": "^8 || ^9"
  },

It also looks like it may possible to get the badge by adding the 'core_version_requirement' key in the modules info.yml file, which, in turn, will add the version to the require section of composer.json. Example follows.

core_version_requirement: ^8 || ^9

Do you want to include the change in this Patch or open a separate issue?

Comment #18

berdir

German

Switzerland

commented 11 February 2020 at 06:32

@jenlampton: That "badge" on the project page is just a text field where the maintainer can add some text, it's not coupled to the module actually being compatible.

That said, yes, this patch should definitely include the .info.yml change.

Comment #19

primsi commented 6 March 2020 at 22:08

Status	File	Size
new	drupal_9_deprecated_code-3042763-19.patch	111.63 KB

Some additional work done here. I did most of the WebTestBase > BrowserTestBase migration. This resulted in a bunch of test fails. Resolved most of them, I think 2 are missing.

Another thing that is missing is to fix FileEntityServicesTest. This should either properly extend ResourceTestBase or - per discussion with @berdir - extend BrowserTestBase with some ResourceTestBase addition.

And finally, there are a bunch of deprecation notices reported by test runs.

End note: interdiff might not be 100% accurate, because I apparently had phpstorm option to commit deletions on. Sry for that.

Comment #20

primsi commented 6 March 2020 at 22:09

Status	File	Size
new	drupal_9_deprecated_code-3042763-19.interdiff.txt	78.8 KB
new	drupal_9_deprecated_code-3042763-19.patch	111.63 KB

... and the interdiff with the patch again.

Comment #21

primsi commented 6 March 2020 at 22:16

Status	File	Size
new	drupal_9_deprecated_code-3042763-21.interdiff.txt	28.54 KB
new	drupal_9_deprecated_code-3042763-21.patch	75.83 KB

2 files were hidden/shown/deleted

Status	File	Size
hidden	drupal_9_deprecated_code-3042763-19.interdiff.txt	78.8 KB
hidden	drupal_9_deprecated_code-3042763-19.patch	111.63 KB

Nope, still not ok.

Comment #22

berdir

German

Switzerland

commented 7 March 2020 at 11:24

Assigned:

Unassigned

» berdir

Comment #23

berdir

German

Switzerland

commented 7 March 2020 at 13:08

Status	File	Size
new	drupal_9_deprecated_code-3042763-23.patch	105.1 KB
new	drupal_9_deprecated_code-3042763-23-interdiff.txt	46.61 KB

Fixed some tests including the REST one and lots of deprecate replacements, should be pretty much done.

Comment #24

7 March 2020 at 13:19

Status:

Needs review

» Needs work

The last submitted patch, 23: drupal_9_deprecated_code-3042763-23.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #25

berdir

German

Switzerland

commented 7 March 2020 at 13:59

Status:

Needs work

» Needs review

Status	File	Size
new	drupal_9_deprecated_code-3042763-25.patch	105.02 KB
new	drupal_9_deprecated_code-3042763-25-interdiff.txt	2.02 KB

Some more fixes/improvements.

Comment #26

berdir

German

Switzerland

commented 7 March 2020 at 14:05

Status	File	Size
new	drupal_9_deprecated_code-3042763-26.patch	105.86 KB
new	drupal_9_deprecated_code-3042763-26-interdiff.txt	864 bytes

And the .info.yml change.

Comment #27

berdir

German

Switzerland

commented 7 March 2020 at 14:11

Status:

Needs review

» Fixed

Committed.

Comment #28

7 March 2020 at 15:11

Berdir committed a84ad1f on 8.x-2.x

Issue #3042763 by Berdir, Primsi, anmolgoyal74, joseph.olstad, Sergiu...

Comment #29

21 March 2020 at 15:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #30

luca_loguercio commented 3 August 2020 at 17:12

Status	File	Size
new	file_entity-3042763-30.patch	101.13 KB

For anyone looking to apply it to beta 7

Comment #31

sharif.elshobkshy commented 13 May 2021 at 18:34

Status	File	Size
new	file_entity-3042763-31.patch	5.17 KB

Beta 8 (8.x-2.0-beta8) has fewer D9 requirements.

New patch to address the following D9 requirements in Beta8 version.

 ------ ----------------------------------------------------------- 
  Line   views/views_plugin_row_file_rss.inc                        
 ------ ----------------------------------------------------------- 
  85     Call to deprecated function file_load_multiple():          
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use      
           \Drupal\file\Entity\File::loadMultiple().                
  112    Call to deprecated function user_load():                   
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use      
           Drupal\user\Entity\User::load().                         
  160    Call to deprecated function drupal_render():               
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use the  
           'renderer' service instead.                              
 ------ -----------------------------------------------------------

Also added some coding standards.

Comment #32

berdir

German

Switzerland

commented 13 May 2021 at 18:57

That file is dead Drupal 7 code, that's going to require a lot more to make sense again. Just ignore it, no need to bother patching that. If anything, create a new issue to figure out if it can safely be removed or if there's anything worth porting over properly.