Problem/Motivation

drupal-check results on commit hash: 13a8a0fc3ca2893f06b6b32dbd9225212ac2a1e4

 ------ ---------------------------------------------------
  Line   src/Form/KeyConfigOverrideDeleteForm.php
 ------ ---------------------------------------------------
  40     Call to deprecated function drupal_set_message().
 ------ ---------------------------------------------------

 ------ ---------------------------------------------------
  Line   src/Form/KeyDeleteForm.php
 ------ ---------------------------------------------------
  70     Call to deprecated function drupal_set_message().
 ------ ---------------------------------------------------

 ------ ---------------------------------------------------
  Line   src/Form/KeyFormBase.php
 ------ ---------------------------------------------------
  331    Call to deprecated function drupal_set_message().
  338    Call to deprecated function drupal_set_message().
  341    Call to deprecated function drupal_set_message().
 ------ ---------------------------------------------------

 ------ ---------------------------------------------------
  Line   src/Plugin/KeyInput/GenerateKeyInput.php
 ------ ---------------------------------------------------
  99     Call to deprecated function drupal_set_message().
 ------ ---------------------------------------------------

 ------ -----------------------------------------------------------------------------------
  Line   tests/src/Functional/KeyAdminTest.php
 ------ -----------------------------------------------------------------------------------
  49     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  52     Call to deprecated method assertRaw() of class Drupal\Tests\BrowserTestBase.
  68     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
  71     Call to deprecated method assertNoText() of class Drupal\Tests\BrowserTestBase.
 ------ -----------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------
  Line   tests/src/Functional/KeyRepositoryServiceTest.php
 ------ --------------------------------------------------------------------------------
  41     Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  44     Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  51     Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  54     Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  59     Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  62     Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  67     Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  74     Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
  81     Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.
 ------ --------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/KeyTestTrait.php (in context of class Drupal\Tests\key\Functional\KeyAdminTest)
 ------ ------------------------------------------------------------------------------------------------------
  37     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
 ------ ------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/KeyTestTrait.php (in context of class Drupal\Tests\key\Functional\KeyNonAdminAccessTest)
 ------ ---------------------------------------------------------------------------------------------------------------
  37     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
 ------ ---------------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/KeyTestTrait.php (in context of class Drupal\Tests\key\Functional\KeyOverrideAdminTest)
 ------ --------------------------------------------------------------------------------------------------------------
  37     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
 ------ --------------------------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/KeyTestTrait.php (in context of class Drupal\Tests\key\Functional\KeyRepositoryServiceTest)
 ------ ------------------------------------------------------------------------------------------------------------------
  37     Call to deprecated method assertResponse() of class Drupal\Tests\BrowserTestBase.
 ------ ------------------------------------------------------------------------------------------------------------------


 [ERROR] Found 23 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 3042718-11.patch6.57 KBrlhawk
#8 3042718-8.patch38.04 KBjcnventura
#8 interdiff.txt30.47 KBjcnventura
#7 3042718-7.patch11.19 KBmanuel garcia
#7 interdiff-3042718-3-7.txt4.16 KBmanuel garcia
#5 deprecated_fix.png134.07 KBarpitr
#3 3042718-3.patch10.75 KBmanuel garcia
#3 interdiff-3042718-2-3.txt1.08 KBmanuel garcia
#2 3042718-2.patch9.67 KBmanuel garcia

Comments

Arrow created an issue. See original summary.

manuel garcia’s picture

manuel garcia commented
Status: Active » Needs review
StatusFileSize
new 3042718-2.patch9.67 KB
manuel garcia’s picture

manuel garcia commented
StatusFileSize
new interdiff-3042718-2-3.txt1.08 KB
new 3042718-3.patch10.75 KB

Great, nothing broke.

Adding here the drupalci file to enable deprecation checking via the test bot.

arpitr’s picture

arpitr commented
Issue tags: +Seattle2019
arpitr’s picture

arpitr commented
StatusFileSize
new deprecated_fix.png134.07 KB

Looks good. Not seeing the warning post applying the patch.
Only local images are allowed.

arpitr’s picture

arpitr commented
Status: Needs review » Reviewed & tested by the community
manuel garcia’s picture

manuel garcia commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new interdiff-3042718-3-7.txt4.16 KB
new 3042718-7.patch11.19 KB

Thanks @arpitr for having a look at this.

Actually since we're making use of MessengerTrait on these classes, we should be calling the messenger like: $this->messenger().

Removed an unused use statement while I was at it.

jcnventura’s picture

jcnventura
Primary language English
commented
StatusFileSize
new interdiff.txt30.47 KB
new 3042718-8.patch38.04 KB

Re-rolled the patch and added a lot more coding standards fixes.

jcnventura’s picture

jcnventura
Primary language English
commented
manuel garcia’s picture

manuel garcia commented
Status: Needs review » Reviewed & tested by the community

Thanks @jcnventura - your clean up looks good. I'm not sure we should be doing that so here since its not in scope, but I'm always up for cleaning up CS so yay.

I think it's safe to go back to RTBC here so doing so.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3042718-11.patch6.57 KB

Thanks for this. I have stripped out the code standards fixes and will create a separate issue for them.

  • rlhawk committed 5f08e09 on 8.x-1.x authored by jcnventura 
    Issue #3042718 by Arrow, Manuel Garcia, jcnventura, arpitr: Drupal 9...
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.