Drupal 9 Deprecated Code Report

@Adrianm6254, Please find the below-attached patch for the same, kindly review it and let me know if any further changes are required.

Thanks

The patch from #2 looks good.

Running drupal-check after patching shows:

./vendor/bin/drupal-check modules/contrib/social_media_links/
 41/41 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors                                                                                                         

Marking as RTBC.

I've run the patch against upgrade status. There is still an outstanding error:

$ drush us-a social_media_links
 [notice] Processing /var/www/drupalvm/drupal/web/modules/contrib/social_media_links.
 41/41 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


================================================================================
Social Media Links Block,  8.x-2.6
Scanned on Thu, 05/28/2020 - 10:02

FILE: web/modules/contrib/social_media_links/social_media_links.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Add `core_version_requirement: ^8 || ^9` to      
                    social_media_links.info.yml to designate that the module is 
                    compatible with Drupal 9. See                               
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

Because of this I've set the status back to Needs work, and added the Novice tag for adding the core_version_requirement option.

Updated patch and added 'core_version_requirement' as mentioned in #5, please review.

Tested the patch and running drupal-check shows 0 errors.

 41/41 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors

+++ b/social_media_links.info.yml
@@ -1,4 +1,5 @@
\ No newline at end of file

Small Nitpick: This could be addressed during commit.

Attached the new patch.

#10 works fine. Thanks

+1 on patch 10 working fine

The core key mst be removed. Tested this on D9.1.x. Works fine.

#13 applied cleanly and works in fresh Drupal 8 and 9 sites.

Patches needs a reroll

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2196  100  2196    0     0   1864      0  0:00:01  0:00:01 --:--:--  1865
error: patch failed: modules/social_media_links_field/social_media_links_field.info.yml:1
error: modules/social_media_links_field/social_media_links_field.info.yml: patch does not apply

working on it. will update shortly

Re-rolled patch from comment #13.

@narendra.rajwar27 i can say SML will support drupal 8, so better to specify core_version_requirement: ^8 || ^9.

@Neslee Canil Pinto thanks for the review, In that case we also need core key. SInce core_version_requirement introduced from drupal 8.8 version.

EDIT: Working on it will update shortly.

Updating patch as per comment #18
Thanks

Oops..forget to change status. Setting to Needs Review.

Committed to dev

@Neslee Canil Pinto
Thanks for committing!
Would you care to cut a new release.

@naveenvalecha ya i have to go with couple of other issues to be committed and then have a release tagged with it soon👍🏻

@naveenvalecha, new release is out - https://www.drupal.org/project/social_media_links/releases/8.x-2.7