Problem/Motivation

drupal-check results on commit hash: d0d2f0695fbd868a58c56b7d232891c2e2018cc2

$ drupal-check image_widget_crop
12/12 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ------------------------------------------------------------------ 
Line   image_widget_crop.install                                         
------ ------------------------------------------------------------------ 
27     Call to deprecated function libraries_detect():                   
Will be removed before a stable Drupal 8 release. Please use the  
new library load and managment concepts described at:             
https://www.drupal.org/node/2170763                               
------ ------------------------------------------------------------------ 

------ ------------------------------------------------------------------ 
Line   image_widget_crop.module                                          
------ ------------------------------------------------------------------ 
102    Call to deprecated function libraries_detect():                   
Will be removed before a stable Drupal 8 release. Please use the  
new library load and managment concepts described at:             
https://www.drupal.org/node/2170763                               
------ ------------------------------------------------------------------ 

------ ------------------------------------------------------------------ 
Line   src/Form/CropWidgetForm.php                                       
------ ------------------------------------------------------------------ 
132    Call to deprecated function libraries_detect():                   
Will be removed before a stable Drupal 8 release. Please use the  
new library load and managment concepts described at:             
https://www.drupal.org/node/2170763                               
------ ------------------------------------------------------------------ 

------ ---------------------------------------------------------------------- 
Line   src/ImageWidgetCropManager.php                                        
------ ---------------------------------------------------------------------- 
107    Call to deprecated function drupal_set_message():                     
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.              
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
132    Call to deprecated function drupal_set_message():                     
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.              
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
147    Call to deprecated function drupal_set_message():                     
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.              
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
172    Call to deprecated function drupal_set_message():                     
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.              
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
339    Call to deprecated function drupal_set_message():                     
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.              
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
386    Call to deprecated function drupal_set_message():                     
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.              
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
418    Call to deprecated function drupal_set_message():                     
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.              
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
------ ---------------------------------------------------------------------- 


[ERROR] Found 10 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#7 image_widget_crop-drupal-9-deprecated-code-3042648-7.patch5.26 KBsvenryen
#2 image_widget_crop-fixed_drupal_set_message-3042648-2.patch5.94 KBi-trokhanenko

Comments

mcdwayne created an issue. See original summary.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Active » Needs review
StatusFileSize
new image_widget_crop-fixed_drupal_set_message-3042648-2.patch5.94 KB

Please review!

Roman Dyn’s picture

Roman Dyn commented
Status: Needs review » Reviewed & tested by the community

Patch #2 looks good. Please commit. Thanks.

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

Updated IS because we have more deprecations in the module that initially communicated.

With the patch applied, the below deprecations still exist:

$ drupal-check .
12/12 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ------------------------------------------------------------------ 
Line   image_widget_crop.install                                         
------ ------------------------------------------------------------------
27     Call to deprecated function libraries_detect():
Will be removed before a stable Drupal 8 release. Please use the
new library load and managment concepts described at:
https://www.drupal.org/node/2170763
------ ------------------------------------------------------------------

------ ------------------------------------------------------------------
Line   image_widget_crop.module
------ ------------------------------------------------------------------
102    Call to deprecated function libraries_detect():
Will be removed before a stable Drupal 8 release. Please use the
new library load and managment concepts described at:
https://www.drupal.org/node/2170763
------ ------------------------------------------------------------------

------ ------------------------------------------------------------------
Line   src/Form/CropWidgetForm.php
------ ------------------------------------------------------------------
132    Call to deprecated function libraries_detect():
Will be removed before a stable Drupal 8 release. Please use the
new library load and managment concepts described at:
https://www.drupal.org/node/2170763
------ ------------------------------------------------------------------


[ERROR] Found 3 errors
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Reviewed & tested by the community

Those aren't drupal core deprecations, that's from the libraries.module.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

We should also add the core_version_requirement key now to all .info.yml files now: https://www.drupal.org/node/3070687

svenryen’s picture

svenryen commented
StatusFileSize
new image_widget_crop-drupal-9-deprecated-code-3042648-7.patch5.26 KB

Should we also consider using $this->t() while we're at this (I know t() isn't deprecated, but $this->t() is considered best practice for oop)?

Here's an alternative patch that uses traits for messages and translation. It also includes core_version_requirement key.

svenryen’s picture

svenryen commented
Status: Needs work » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

I applied this patch and ran drupal-check on it; it turned up no errors. So, once tests pass, I think this is ready to be committed.

  • phenaproxima committed 39fe78d on 8.x-2.x 
    Issue #3042648 by svenryen, i-trokhanenko, Berdir, anavarre: Drupal 9...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.