Drupal 9 Deprecated Code Report

Here is the patch, please review.

Updating the issue because I'm seeing many more deprecation notices with 8.x-4.x. Speaking of which, shouldn't we target 8.x-3.x since it's the current recommended release?

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.

I have fixed most of the deprecated errors , kindly review the patch.

There are errors in applying the patch, please rectify them.
It seems few core files too have been patched up , and are having issue applying patch please check again.

Hi @shubhangi1995 thanks for review patch, i am attaching new patch.

Thanks all for your work on these updates.

Below are a few places where we could be injecting services. Because we are changing existing services, we also need a new empty update that will trigger a container rebuild--at least, last I knew this was needed. An example is features_update_8300():

/**
 * Rebuild the container to add a parameter to the features.manager service.
 */
function features_update_8300() {
  // Empty update to cause a cache rebuild so that the container is rebuilt.
}

1. +++ b/modules/features_ui/src/Form/AssignmentExcludeForm.php
   @@ -60,7 +68,7 @@ class AssignmentExcludeForm extends AssignmentFormBase {
   +    $info = \Drupal::service('extension.list.$type')->getExtensionInfo('module', \Drupal::installProfile());
   

   Both the extension list and the install profile services could/should be injected.

2. +++ b/src/Plugin/FeaturesAssignment/FeaturesAssignmentExclude.php
   @@ -66,7 +66,7 @@ class FeaturesAssignmentExclude extends FeaturesAssignmentMethodBase {
   +          $profile_name = \Drupal::installProfile();
   

   Ideally we would inject this service.

3. +++ b/src/Plugin/FeaturesGeneration/FeaturesGenerationArchive.php
   @@ -156,9 +159,9 @@ class FeaturesGenerationArchive extends FeaturesGenerationMethodBase implements
   +    $archive_name = \Drupal::service('file_system')->getTempDirectory() . '/' . $this->archiveName;
   

   Ideally we would inject this service.

Patch to remove depricated code

@nitesh624 thank you for your contribution.

Without further information, it is difficult for me as a maintainer to know what you've done or why.

The following would help a lot:

• Describe the specific changes you've made compared to the previous patch. Why did you upload a new version?
• Refer to the latest review I provided above. Have you addressed any of the remaining issues I identified? If so, which ones and how?
• Provide an interdiff; see the relevant documentation.

Thanks!

Since this the original deprecated code report was run over a year ago, attached is the following:

1. 2020/04/02 Deprecated code report as generated by drupal-check on the 8.x-3.x branch: 46 errors
2. Autogenerated fixes to deprecated code, as performed by palantirnet/drupal-rector
3. Deprecated code report after the patch was applied: 27 errors

Perhaps these automated fixes can be committed first. Then we can focus on a more narrow amount of work for fixing the remaining items which cannot be automatically fixed.

The attached patch adds the new core_incompatible value to the Kernel test that was failing, as well as the core_version_requirement in the info.yml file, per Drupal 9 compatibility requirements.

We should still expect deprecations, but this will take care of the low-hanging fruit, and we can move onto the manual work next.

To do: Per https://www.drupal.org/pift-ci-job/1659628, the FeaturesUI test will need to be updated to not use simpletest.

Thanks, I've applied that initial patch, minus this part:

The attached patch adds the new core_incompatible value to the Kernel test that was failing

We can take care of that in #3122684: core_incompatible: false.

Setting to "Needs work" for the remaining D9 compatibility fixes.

This issue has had a lot of contributors (thanks!) but not a lot of continuity between efforts, with the result that it's been hard as a maintainer to know where we stand.

If updating, please see my comment in #17.

We'll apply this to both 8.x-4.x and 8.x-3.x (which at this point are identical).

Attached is a patch that contains the portions that still apply from #12 and #16. This is very likely to fail testing.

My comments from #13 likely still mostly apply, with the difference that instead of hook_update_N() we should be using hook_post_update_NAME(). See Use hook_post_update_NAME instead of hook_update_N to clear the cache.

Setting to Needs review only to see what test failures we get.

The patch I posted in #31, drawing on previous work in this issue, was too broken to be of use.

I've posted a few new fixes drawing on #3140493: Automated Drupal Rector fixes supplemented with manual fixes to service injection and such.

Setting to Needs work for the (considerable) remaining work.

A further round of fixes to run by the test bot.

Fix typo.

Fixes are in tests that need updating.

Applying the non-test deprecation fixes.

Address some more test failures.

A few more attempted fixes.

The remaining issues appear to be tests that need updating rather than necessarily further deprecations in the module code that need fixing. Moving to a separate-follow-up issue.

Follow-up work will be done in #3144232: Drupal 9 compatibility for Features, manual deprecation detection and #3143916: Tests failing after Drupal 9 update.