Drupal 9 Deprecated Code Report [#3042596]

Problem/Motivation

source : [git] https://git.drupal.org/project/embed fcc97638807dd981207175d027d0f2ea7a8bbc41

Results from Drupal Check:

 ------ ------------------------------------------------------------------------------- 
  Line   src/Entity/EmbedButton.php                                                     
 ------ ------------------------------------------------------------------------------- 
  118    Call to deprecated method entityManager() of class Drupal\Core\Entity\Entity.  
  141    Call to deprecated method entityManager() of class Drupal\Core\Entity\Entity.  
 ------ ------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------- 
  Line   src/Form/EmbedButtonForm.php                                                      
 ------ ---------------------------------------------------------------------------------- 
  105    Call to deprecated function drupal_set_message().                                 
  122    Call to deprecated function drupal_set_message().                                 
  199    Call to deprecated function drupal_set_message().                                 
  202    Call to deprecated function drupal_set_message().                                 
  203    Call to deprecated method link() of class Drupal\Core\Entity\EntityInterface.     
  207    Call to deprecated method urlInfo() of class Drupal\Core\Entity\EntityInterface.  
 ------ ---------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------- 
  Line   tests/embed_test/src/Plugin/EmbedType/Aircraft.php  
 ------ ---------------------------------------------------- 
  62     Call to deprecated function drupal_set_message().   
 ------ ----------------------------------------------------

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#24	3042596-fix-drupal9-deprecations.patch	10.73 KB	dave reid
#23	3042596-fix-drupal9-deprecations.patch	10.7 KB	dave reid
#20	3042596-fix-drupal9-deprecations.patch	11.31 KB	dave reid
#16	interdiff-3042596-15-16.txt	890 bytes	sharique
#16	3042596-16.patch	5.51 KB	sharique
#15	3042596-15.patch	4.69 KB	joegraduate
#15	3042596-interdiff_14-15.txt	2.41 KB	joegraduate
#14	3042596-14.patch	5.19 KB	joegraduate
#14	3042596-interdiff_11-14.txt	1.27 KB	joegraduate
#11	3042596-interdiff_7-8.txt	747 bytes	joegraduate
#11	3042596-8.patch	4.42 KB	joegraduate
#8	3042596-interdiff_4-7.txt	1.87 KB	joegraduate
#8	3042596-7.patch	4.41 KB	joegraduate
#6	3042596-interdiff_4-6.txt	1.16 KB	joegraduate
#6	3042596-6.patch	3.7 KB	joegraduate
#4	3042596-4.patch	3.69 KB	mohammad-fayoumi
#2	drupal_9_deprecated_code-3042596-2.patch	6.38 KB	sergiu stici

Comments

Comment #1

23 March 2019 at 16:56

oheller created an issue. See original summary.

Status	File	Size
new	drupal_9_deprecated_code-3042596-2.patch	6.38 KB

Comment #3

30 April 2019 at 15:36

Status:

Needs review

» Needs work

The last submitted patch, 2: drupal_9_deprecated_code-3042596-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #4

mohammad-fayoumi

English

Amman

commented 30 July 2019 at 08:02

Status	File	Size
new	3042596-4.patch	3.69 KB

Comment #5

mohammad-fayoumi

English

Amman

commented 30 July 2019 at 08:28

Status:

Needs work

» Needs review

Comment #6

joegraduate

English

Arizona, USA

commented 5 October 2019 at 06:32

Issue tags:

+badcamp2019

Status	File	Size
new	3042596-6.patch	3.7 KB
new	3042596-interdiff_4-6.txt	1.16 KB

Attached patch is a modified version of #4 which should hopefully fix the failing tests.

FWIW, it looks like it might actually be preferable to replace EntityManager::loadEntityByUuid with EntityRepositoryInterface::loadEntityByUuid() (like was started in #2).

BADcamp info: Blue Queen of Clubs

Comment #7

5 October 2019 at 06:35

Status:

Needs review

» Needs work

The last submitted patch, 6: 3042596-6.patch, failed testing. View results

Comment #8

joegraduate

English

Arizona, USA

commented 5 October 2019 at 07:28

Status	File	Size
new	3042596-7.patch	4.41 KB
new	3042596-interdiff_4-7.txt	1.87 KB

2 files were hidden/shown/deleted

Status	File	Size
hidden	3042596-6.patch	3.7 KB
hidden	3042596-interdiff_4-6.txt	1.16 KB

Attached patch adds EntityRepositoryInterface as a dependency and replaces EntityManager::loadEntityByUuid() with EntityRepositoryInterface::loadEntityByUuid() instead of using EntityStorageInterface::loadByProperties(), similar to #2 but it also includes a \Drupal::service() fallback.

Hopefully this fixes the failing tests better than #6.

BADcamp info: Blue Queen of Clubs

Comment #9

joegraduate

English

Arizona, USA

commented 5 October 2019 at 07:26

Status:

Needs work

» Needs review

Comment #10

5 October 2019 at 07:29

Status:

Needs review

» Needs work

The last submitted patch, 8: 3042596-7.patch, failed testing. View results

Comment #11

joegraduate

English

Arizona, USA

commented 5 October 2019 at 07:35

Status:

Needs work

» Needs review

Status	File	Size
new	3042596-8.patch	4.42 KB
new	3042596-interdiff_7-8.txt	747 bytes

2 files were hidden/shown/deleted

Status	File	Size
hidden	3042596-7.patch	4.41 KB
hidden	3042596-interdiff_4-7.txt	1.87 KB

Made EntityRepositoryInterface dependency optional.

BADcamp info: Blue Queen of Clubs

Comment #12

5 October 2019 at 07:38

Status:

Needs review

» Needs work

The last submitted patch, 11: 3042596-8.patch, failed testing. View results

Comment #13

joegraduate

English

Arizona, USA

commented 5 October 2019 at 20:18

I believe the remaining test that is failing, Drupal\Tests\embed\Kernel\IconFileUsageTest::testEmbedButtonIconUsage, is actually failing due to this core change: https://www.drupal.org/node/2891902 and may no longer be valid.

Comment #14

joegraduate

English

Arizona, USA

commented 7 October 2019 at 18:13

Status:

Needs work

» Needs review

Status	File	Size
new	3042596-interdiff_11-14.txt	1.27 KB
new	3042596-14.patch	5.19 KB

2 files were hidden/shown/deleted

Status	File	Size
hidden	3042596-8.patch	4.42 KB
hidden	3042596-interdiff_7-8.txt	747 bytes

Added fix for failing test from #3002291: IconFileUsageTest fails after change in Drupal 8.4 and fixed docblock for EmbedButton::__contstruct().

Comment #15

joegraduate

English

Arizona, USA

commented 7 October 2019 at 20:21

Status	File	Size
new	3042596-interdiff_14-15.txt	2.41 KB
new	3042596-15.patch	4.69 KB

2 files were hidden/shown/deleted

Status	File	Size
hidden	3042596-interdiff_11-14.txt	1.27 KB
hidden	3042596-14.patch	5.19 KB

Made the code for loading the EntityRepository service more like the existing service-loading methods on the EmbedButton class. This is now ready for serious review IMHO.

Comment #16

sharique commented 21 November 2019 at 11:02

Status	File	Size
new	3042596-16.patch	5.51 KB
new	interdiff-3042596-15-16.txt	890 bytes

There one more deprecation.

  embed git:(8.x-1.x) ✗ drupal-check .
 28/28 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------------------------------------------------------------------
  Line   src/EmbedType/EmbedTypeInterface.php
 ------ ---------------------------------------------------------------------------------------------------------------------------------------
  14     Interface Drupal\embed\EmbedType\EmbedTypeInterface extends deprecated interface Drupal\Component\Plugin\ConfigurablePluginInterface:
         Drupal\Component\Plugin\ConfigurablePluginInterface is deprecated
         in Drupal 8.7.0 and will be removed before Drupal 9.0.0. You should implement
         ConfigurableInterface and/or DependentPluginInterface directly as needed. If
         you implement ConfigurableInterface you may choose to implement
         ConfigurablePluginInterface in Drupal 8 as well for maximum compatibility,
         however this must be removed prior to Drupal 9.
 ------ 

 [ERROR] Found 1 error

I updated patch to address it.

Comment #17

joshi.rohit100

he/him

Hindi

Delhi, India

commented 23 November 2019 at 10:23

Status:

Needs review

» Needs work

After applying the patch in #16, I still see deprecation errors -

 28/28 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------------------------
  Line   src/Tests/EmbedTestBase.php
 ------ ------------------------------------------------------------------------------------------------
  13     Class Drupal\embed\Tests\EmbedTestBase extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  46     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ ------------------------------------------------------------------------------------------------


 [ERROR] Found 2 errors

Comment #18

andreyjan commented 26 November 2019 at 14:01

Status:

Needs work

» Needs review

Regarding to #17, I've created a separate issue to convert SimpleTest tests to FunctionalJavascript https://www.drupal.org/project/embed/issues/3096857, so moving this to needs review back,

Comment #19

joshi.rohit100

he/him

Hindi

Delhi, India

commented 27 November 2019 at 04:17

Status:

Needs review

» Reviewed & tested by the community

Comment #20

dave reid

he/him

English

Nebraska USA

commented 6 December 2019 at 20:24

Status:

Reviewed & tested by the community

» Needs review

Status	File	Size
new	3042596-fix-drupal9-deprecations.patch	11.31 KB

This was missing the DependentPluginInterface on EmbedTypeInterface. I also cleaned up a few more things and made the modules installable by default on Drupal 9.

English

Nebraska USA

commented 6 December 2019 at 20:29

Status	File	Size
new	3042596-fix-drupal9-deprecations.patch	10.7 KB

Re-rolled now that the blockers were merged.

Comment #24

dave reid

he/him

English

Nebraska USA

commented 6 December 2019 at 20:46

Status	File	Size
new	3042596-fix-drupal9-deprecations.patch	10.73 KB

Should resolve the test now.

Comment #25

6 December 2019 at 20:57

Dave Reid committed a7004dc on 8.x-1.x

Issue #3042596 by joegraduate, Dave Reid, Sharique, Mohammad Fayoumi,...

Comment #26

dave reid

he/him

English

Nebraska USA

commented 6 December 2019 at 20:58

Status:

Needs review

» Fixed

Committed #24 to 8.x-1.x. Thanks all!

Comment #27

20 December 2019 at 20:59

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Drupal 9 Deprecated Code Report

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Referenced by