Drupal 9 Deprecated Code Report [#3042586]

Problem/Motivation

As of commit e935322714de920f9378958b801cd3ab58f3d7e8



 ------ -------------------------------------------------------------------------------------- 
  Line   captcha.module                                                                        
 ------ -------------------------------------------------------------------------------------- 
  257    Call to deprecated method url() of class Drupal\Core\Config\Entity\ConfigEntityBase.  
  320    Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode.     
  320    Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode.     
  350    Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode.     
  350    Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode.     
 ------ -------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------ 
  Line   image_captcha/src/Controller/CaptchaImageRefresh.php  
 ------ ------------------------------------------------------ 
  46     Call to deprecated method url() of class Drupal.      
 ------ ------------------------------------------------------ 

 ------ ----------------------------------------------------- 
  Line   image_captcha/src/Form/ImageCaptchaSettingsForm.php  
 ------ ----------------------------------------------------- 
  75     Call to deprecated function drupal_set_message().    
 ------ ----------------------------------------------------- 

 ------ ----------------------------------------------------------- 
  Line   modules/captcha_long_form_id_test/src/Form/LongIdForm.php  
 ------ ----------------------------------------------------------- 
  44     Call to deprecated function drupal_set_message().          
 ------ ----------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/CaptchaPointDeleteForm.php                
 ------ --------------------------------------------------- 
  40     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/CaptchaPointDisableForm.php               
 ------ --------------------------------------------------- 
  48     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/CaptchaPointEnableForm.php                
 ------ --------------------------------------------------- 
  48     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/CaptchaPointForm.php                      
 ------ --------------------------------------------------- 
  104    Call to deprecated function drupal_set_message().  
  109    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/CaptchaSettingsForm.php                   
 ------ --------------------------------------------------- 
  237    Call to deprecated function drupal_set_message().  
  252    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 [ERROR] Found 15 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#19	interdiff-3042586-16-17.txt	6.89 KB	jeroent
#17	3042586-17.patch	8.77 KB	jeroent
#16	13063891-16-D8.patch	7.79 KB	yogen.prasad
#13	13063891-13-D8.patch	7.58 KB	yogen.prasad
#10	13063891-8-D8.patch	7.16 KB	yogen.prasad
#6	captcha-readiness-3042586-6-D8.patch	8.73 KB	thalles
#4	3042586-captcha-d9-readiness-4.patch	8.24 KB	chaseontheweb
#2	3042586-captcha-d9-readiness-2.patch	8.24 KB	chaseontheweb

Comments

Comment #1

23 March 2019 at 16:39

ChaseOnTheWeb created an issue. See original summary.

Comment #2

chaseontheweb

USA

commented 25 March 2019 at 17:49

Status:

Active

» Needs review

Status	File	Size
new	3042586-captcha-d9-readiness-2.patch	8.24 KB

Patch attached to address all listed issues.

Strtolower is a simple find/replace per CR #2850048: Use mb_* functions instead of Unicode::* methods. drupal_set_message is also a simple find/replace for anything implementing FormBase per CR #2774931: drupal_set_message() and drupal_get_messages() replaced by Messenger service.

I think I updated the url() calls correctly. I will test out and update the patch if not. I'm new to D8/9 development. I submitted this as part of a contribution sprint at MidCamp 2019.

Comment #3

25 March 2019 at 17:54

Status:

Needs review

» Needs work

The last submitted patch, 2: 3042586-captcha-d9-readiness-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status	File	Size
new	3042586-captcha-d9-readiness-4.patch	8.24 KB

Status	File	Size
hidden	3042586-captcha-d9-readiness-2.patch	8.24 KB

Comment #5

25 March 2019 at 18:13

Status:

Needs review

» Needs work

The last submitted patch, 4: 3042586-captcha-d9-readiness-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status	File	Size
new	captcha-readiness-3042586-6-D8.patch	8.73 KB

Comment #7

thalles

Portuguese, Brazil

Teófilo Otoni - MG

commented 26 March 2019 at 14:02

Status:

Needs work

» Needs review

Comment #8

26 March 2019 at 14:07

Status:

Needs review

» Needs work

The last submitted patch, 6: captcha-readiness-3042586-6-D8.patch, failed testing. View results

Comment #9

yogen.prasad commented 11 April 2019 at 19:10

Assigned:	Unassigned	» yogen.prasad
Issue tags:		+Seattle2019

Comment #10

yogen.prasad commented 11 April 2019 at 21:40

Status	File	Size
new	13063891-8-D8.patch	7.16 KB

Comment #11

yogen.prasad commented 12 April 2019 at 17:00

Status:

Needs work

» Needs review

Comment #12

arpitr commented 12 April 2019 at 22:55

Status:

Needs review

» Needs work

Thanks @yogenprasad for working on this.

Few issues which I see

1. There is one pending deprecated message

------ --------------------------------------------------------------------------------------
Line captcha.module
------ --------------------------------------------------------------------------------------
257 Call to deprecated method url() of class Drupal\Core\Config\Entity\ConfigEntityBase.
------ --------------------------------------------------------------------------------------

[ERROR] Found 1 error

2. Instead of using the procedural way of drupal set message if we can use Messenger Trait
Replace
+ \Drupal::messenger()->addMessage
with Messenger Trait as in example
https://www.drupal.org/node/2774931

Comment #13

yogen.prasad commented 21 April 2019 at 07:47

Status:

Needs work

» Needs review

Status	File	Size
new	13063891-13-D8.patch	7.58 KB

Changes done as per suggestions.

Comment #14

yogen.prasad commented 21 April 2019 at 07:48

Assigned:

yogen.prasad

» Unassigned

Comment #15

21 April 2019 at 07:58

Status:

Needs review

» Needs work

The last submitted patch, 13: 13063891-13-D8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #16

yogen.prasad commented 21 April 2019 at 14:30

Status	File	Size
new	13063891-16-D8.patch	7.79 KB

Comment #17

jeroent

Dutch

🇧🇪

commented 14 May 2019 at 07:37

Status:

Needs work

» Needs review

Status	File	Size
new	3042586-17.patch	8.77 KB

5 files were hidden/shown/deleted

Status	File	Size
hidden	3042586-captcha-d9-readiness-4.patch	8.24 KB
hidden	captcha-readiness-3042586-6-D8.patch	8.73 KB
hidden	13063891-8-D8.patch	7.16 KB
hidden	13063891-13-D8.patch	7.58 KB
hidden	13063891-16-D8.patch	7.79 KB

Comment #18

thalles

Portuguese, Brazil

Teófilo Otoni - MG

commented 14 May 2019 at 12:01

@JeroenT, can you post the interdiff?

Comment #19

jeroent

Dutch

🇧🇪

commented 14 May 2019 at 15:11

Status	File	Size
new	interdiff-3042586-16-17.txt	6.89 KB

Added interdiff.

Comment #20

thalles

Portuguese, Brazil

Teófilo Otoni - MG

commented 14 May 2019 at 16:45

Status:

Needs review

» Reviewed & tested by the community

Thanks @JeroenT!

Comment #21

wundo commented 15 May 2019 at 11:52

Comment #22

wundo commented 15 May 2019 at 11:53

Status:

Reviewed & tested by the community

» Fixed

Comment #23

15 May 2019 at 11:53

wundo committed d3c9b8e on 8.x-1.x authored by JeroenT

Issue #3042586 by yogen.prasad, ChaseOnTheWeb, JeroenT, thalles, arpitr...

Comment #24

wundo commented 15 May 2019 at 11:56

Thanks, committed

Comment #25

andrtroe commented 27 May 2019 at 07:02

Issue tags:

+Captcha Release 8.x-1.0

Comment #26

10 June 2019 at 07:04

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #27

Steven Brown commented 5 March 2020 at 17:44

Run against 6731656. Here are some new deprecations since this issue was closed.

 ------ ----------------------------------------------------------------------------------------------------------------------
  Line   src/Tests/CaptchaSessionReuseAttackTestCase.php
 ------ ----------------------------------------------------------------------------------------------------------------------
  16     Class Drupal\captcha\Tests\CaptchaSessionReuseAttackTestCase extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  70     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ ----------------------------------------------------------------------------------------------------------------------

Drupal 9 Deprecated Code Report

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Referenced by