When we configure multiple keywords only one keyword is getting replaced, while the rest remains unaltered

The version of alinks being used is 8.x-1.1

CommentFileSizeAuthor
#2 replace_all_keywords.patch361 bytesmukundhraj

Issue fork alinks-3042282

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mukundhraj created an issue. See original summary.

mukundhraj’s picture

mukundhraj commented
StatusFileSize
new replace_all_keywords.patch361 bytes

After tracing the code we found that there was a break statement in "AlinkPostRenderer.php" which was causing only one keyword to get replaced while the rest was not accounted for so on removal of the break statement itseems to replace all keywords. Created a patch and have attached the same. Please check

adao.boscolo’s picture

adao.boscolo commented

Hi @mukundhraj

Thanks for the patch.

I applied to Drupal 9 (9.3.15) and version 2.0.0 of module but not work.

Only the first keyword is replaced.

If you need help testing this patch again, I can help you.

Thanks!

bbu23’s picture

bbu23
Location 🇪🇺🇪🇺🇪🇺
commented
Version: 8.x-1.1 » 2.0.0

bbu23 opened merge request !1

bbu23’s picture

bbu23
Location 🇪🇺🇪🇺🇪🇺
commented
Status: Active » Needs review

I added an option in the settings form (/admin/config/content/alinks) to choose between replace all or replace first. Defaults to replace first. This setting is global as a quick solution.

drupaldope’s picture

drupaldope commented

resolved in the current dev release
https://www.drupal.org/project/alinks/issues/3412674

drupaldope’s picture

drupaldope commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.