It's kind of annoying that you have to enter the URL every time you use the static generator form. We should use state to remember the last URL.

CommentFileSizeAuthor
#4 interdiff-3042117-2-4.txt3.88 KBsamuel.mortenson
#4 3042117-4.patch4.09 KBsamuel.mortenson
#2 3042117-2-base-url-variable.patch2.34 KBplopesc

Comments

samuel.mortenson created an issue. See original summary.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 3042117-2-base-url-variable.patch2.34 KB

Hello.

I really missed this feature while I was testing the module. So once I discovered it is in the roadmap, I worked on a patch for it.

Besides of the addition of the new state variable, also a cleanup hook_uninstall module has been implemented.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented

While we are here, you may consider to rename the module state variables from tome_static_xxxx to tome_static.xxxx in order to be consistent with state variables names declared in other modules or core.

Cheers

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
StatusFileSize
new 3042117-4.patch4.09 KB
new interdiff-3042117-2-4.txt3.88 KB

@plopesc I changed some naming around per your comment and my review. Does this look good to you?

I also filed #3046316: Static command does not set building state flag since I realized the commands aren't ever setting the building state.

  • samuel.mortenson authored c8bbeec on 8.x-1.x 
    Issue #3042117 by samuel.mortenson, plopesc: Remember last URL in the...
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Needs review » Fixed

@plopesc I'm doing a bit of a sprint at Drupalcon so I'm going to go ahead and commit this. Thanks for the contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.