Problem/Motivation

FilterEntityBundleTest makes no HTTP requests but is a functional test

Proposed resolution

Convert FilterEntityBundleTest into a Kernel test

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#11 interdiff.3041778.10-11.txt596 bytesmikelutz
#11 3041778-11.drupal.Convert-FilterEntityBundleTest-into-a-kernel-test.patch5.27 KBmikelutz
#10 interdiff.3041778.2-10.txt540 bytesmikelutz
#10 3041778-10.drupal.Convert-FilterEntityBundleTest-into-a-kernel-test.patch5.27 KBmikelutz
#2 3041778-2.patch4.74 KBclaudiu.cristea

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Needs review
StatusFileSize
new 3041778-2.patch4.74 KB

This patch decreases the locally test run from 8 to 2.5 seconds.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Reviewed & tested by the community

Nice, compared before and after and can find no loss of coverage.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 1eabc0b846 to 8.8.x and b12561bd43 to 8.7.x. Thanks!

As a test only change backported to 8.7.x - I discussed backporting test-only changes with @catch (as a release manager).

  • alexpott committed 1eabc0b on 8.8.x 
    Issue #3041778 by claudiu.cristea: Convert FilterEntityBundleTest into a...

  • alexpott committed b12561b on 8.7.x 
    Issue #3041778 by claudiu.cristea: Convert FilterEntityBundleTest into a...

  • alexpott committed 1d29b74 on 8.8.x 
    Revert "Issue #3041778 by claudiu.cristea: Convert...

  • alexpott committed f72f03b on 8.7.x 
    Revert "Issue #3041778 by claudiu.cristea: Convert...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Fixed » Needs work

Had to revert this because it is failing on PHP 5.5 - we still have tests on PHP 5 so can't commit this without fixing that first. And we'll have PHP 5 testing for the life of 8.7.x so if we want to commit this there we definitely need to fix this.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3041778-10.drupal.Convert-FilterEntityBundleTest-into-a-kernel-test.patch5.27 KB
new interdiff.3041778.2-10.txt540 bytes

Hey, it's our old friend, undefined sort orders!

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
StatusFileSize
new 3041778-11.drupal.Convert-FilterEntityBundleTest-into-a-kernel-test.patch5.27 KB
new interdiff.3041778.10-11.txt596 bytes

gah..

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Reviewed & tested by the community

This was once RTBCed. I’m doing it only for #10, #11 changes (if the bot agrees)

  • larowlan committed c0f3934 on 8.8.x 
    Issue #3041778 by mikelutz, claudiu.cristea, alexpott: Convert...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed c0f3934 and pushed to 8.8.x. Thanks!
c/p as d0ebe15f94 and pushed to 8.7.x

  • larowlan committed d0ebe15 on 8.7.x 
    Issue #3041778 by mikelutz, claudiu.cristea, alexpott: Convert...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

2pha’s picture

2pha
Primary language English
commented

The sorting from this patch creates an issue:
https://www.drupal.org/project/drupal/issues/3097765