Patch coming up - easy 1-line fix

CommentFileSizeAuthor
#6 geocoder.proximity-cache.3041554-6.patch343 bytesadamps
#2 geocoder.proximity-cache.3041554-2.patch313 bytesadamps

Comments

AdamPS created an issue. See original summary.

adamps’s picture

adamps commented
Status: Active » Needs review
StatusFileSize
new geocoder.proximity-cache.3041554-2.patch313 bytes

  • itamair committed 8a86bbe on 8.x-2.x authored by AdamPS 
    Issue #3041554 by AdamPS: GeocodeOrigin never writes to...
itamair’s picture

itamair commented

Thanks @AdamPS ... committed into dev.

itamair’s picture

itamair commented
Status: Needs review » Fixed
adamps’s picture

adamps commented
Status: Fixed » Needs review
StatusFileSize
new geocoder.proximity-cache.3041554-6.patch343 bytes

Thanks @itamair.

Sorry my patch wasn't quite right. We should also cache an error result = location not found. This saves wasted repeat lookups and avoids multiple error logs for the same request. Here is a new patch that does that.

  • itamair committed d044ab9 on 8.x-2.x authored by AdamPS 
    Issue #3041554 by AdamPS, itamair: GeocodeOrigin never writes to...
itamair’s picture

itamair commented

Ok @AdamPS ... trusting you. Re-committed into dev

itamair’s picture

itamair commented
Status: Needs review » Fixed
adamps’s picture

adamps commented

Great thanks for trusting me

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.