Looking at the code, I assume that a site using this module must have a bootstrap theme... more then that, it must use the bootstrap's 3.x version. (not the 4.x version)
If I am correct, we should update the module description/documentation

Comments

DuneBL created an issue. See original summary.

thejimbirch’s picture

thejimbirch commented

Hi!

The requirements section of the readme and module page state that:

Bootstrap framework's CSS and JS included in your theme

I tried to write the module in a way that was Bootstrap version 3/4 agnostic. We have an issue open for version 4, but no one has reported any major issues:

https://www.drupal.org/project/bootstrap_paragraphs/issues/2861474

What else were you thinking we needed? Or have you run into issues?

Thanks,
Jim

dunebl’s picture

dunebl
Primary language French
commented

Thank you!
The provided link assume that only the carousel have issue with BS4. This is a nice!!!
I will start using it with Barrio and let you know if any other issue.

I would add:

1-Without digging too much, I was nearly sure that this module was not BS4 compatible... Thus, we could change the requirement into:

Bootstrap (3.x or 4.x) framework's CSS and JS included in your theme

This could increase the use of this module by the lazy developers who didn't dig too much (like me)

2-As a feature request, we could add a switch in the module config "BS4 or BS3" and use it to solve the carousel issue and any other issue that could pop-up. What do you think?

devkinetic’s picture

devkinetic commented

+1 for this, this module needs more BS4 usage, the description does not specify.

  • thejimbirch committed 880c44e on 8.x-2.x 
    Issue #3041028 by thejimbirch: Update doc to target the right bootstrap...
thejimbirch’s picture

thejimbirch commented
Status: Active » Fixed

I updated the wording on the module page and in the readme in the dev branch. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.