Hi,

It would be good to have a checkbox in the backoffice to remove all the default CSS. If you want to create your own theme, it is quite annoying to have to override the rules of the module.

The javascript is part of the feature, the CSS not really and we can add like a warning "removing the CSS can break the interface" . Only developers will use this option.

We just have to split the CSS from the JS in the libraries and add the CSS libraries only when the checkbox is checked.

CommentFileSizeAuthor
#10 private_message-allow_remove_default_style-3040698-10.patch14.95 KBphjou
#6 private_message-allow_remove_default_style-3040698-6.patch15.01 KBphjou
#5 private_message-allow_remove_default_style-3040698-5.patch15.03 KBphjou
#3 private_message-allow_remove_default_style-3040698-2-beta15.patch16.71 KBphjou
#2 private_message-allow_remove_default_style-3040698-2.patch15.66 KBphjou

Comments

phjou created an issue. See original summary.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new private_message-allow_remove_default_style-3040698-2.patch15.66 KB

Just did a patch for this

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
StatusFileSize
new private_message-allow_remove_default_style-3040698-2-beta15.patch16.71 KB

Just a patch for the beta15 in case some people need this patch because the dev branch is buggy.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Title: Allow to remove the default syle » Allow to remove the default style
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Parent issue: » #3042196: Autofocus should be configurable
StatusFileSize
new private_message-allow_remove_default_style-3040698-5.patch15.03 KB

Just rerolled the patch but also added a parent in order to avoid to reroll it again. So just need to merge in order and it should work.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
StatusFileSize
new private_message-allow_remove_default_style-3040698-6.patch15.01 KB

The patch does work when using composer but I couldn't apply it by using git. So I just rerolled the patch in case it helps.

anmolgoyal74’s picture

anmolgoyal74 commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Needs work » Postponed

This patch will have to be rerolled after #3038271: Inbox not working properly and #3058364: Press "Enter" to send

Postponed for now

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Postponed » Needs work

#3058364: Press "Enter" to send is in! We can reroll the patch now.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
StatusFileSize
new private_message-allow_remove_default_style-3040698-10.patch14.95 KB

Patch rerolled

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Needs work » Needs review
zenimagine’s picture

zenimagine commented

@phjou Thanks, the patch works for me

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Thanks for testing!

  • phjou committed 6a1b528 on 8.x-2.x 
    Issue #3040698 by phjou, zenimagine: Allow to remove the default style
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.