Use "PHP CodeSniffer" to get the formatting issue & update the codebase

please find the report CoderReport.txt

CommentFileSizeAuthor
#6 freport_coding_standard_3040527-6.patch10.71 KBkkalaskar
#5 3040527-5.patch10.71 KBgovind.maloo
#2 freport_coding_standard_3040527-2.patch9.76 KBpatelmayank7552
CoderReport.txt27.71 KBxaiwant

Comments

xaiwant created an issue. See original summary.

patelmayank7552’s picture

patelmayank7552 commented
StatusFileSize
new freport_coding_standard_3040527-2.patch9.76 KB

Hi,

I have created the patch to fix the coding standard issue using PHP CodeSniffer.

Thanks

patelmayank7552’s picture

patelmayank7552 commented
Status: Needs work » Needs review
govind.maloo’s picture

govind.maloo commented
Status: Needs review » Needs work

Unable to apply patch, require more work.

git apply freport_coding_standard_3040527-2.patch 
error: patch failed: freport.info:2
error: freport.info: patch does not apply
govind.maloo’s picture

govind.maloo commented
Status: Needs work » Needs review
StatusFileSize
new 3040527-5.patch10.71 KB
kkalaskar’s picture

kkalaskar commented
StatusFileSize
new freport_coding_standard_3040527-6.patch10.71 KB

@govindmaloo
I applied the patch on the local instance. and run the following commands, found 2 issues. I fixed it please review once.

$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md freport.module

FILE: C:\xampp\htdocs\d7-new\sites\all\modules\contrib\freport\freport.module
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------

Time: 406ms; Memory: 8MB


$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md templates/page--admin--reports--freport.tpl.php

FILE: C:\xampp\htdocs\d7-new\sites\all\modules\contrib\freport\templates\page--admin--reports--freport.tpl.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------

Time: 287ms; Memory: 6MB
vishakraman’s picture

vishakraman commented
Assigned: Unassigned » vishakraman
Status: Needs review » Fixed
Issue tags: -Novice +IttbHackathon

Patch Applied, seems working fine!

vishakraman’s picture

vishakraman commented
Status: Fixed » Closed (fixed)