Use dependency injection

This is awesome. There were a few bugs (fixed them w @hawkeye.twolf's help). But there are more (see error below).

Current status attached.

( ! ) Fatal error: Declaration of Drupal\quicklink\Form\QuicklinkConfigForm::create(Drupal\quicklink\Form\ContainerInterface $container) must be compatible with Drupal\Core\Form\ConfigFormBase::create(Symfony\Component\DependencyInjection\ContainerInterface $container) in /Users/mherchel/sites/quicklink/src/Form/QuicklinkConfigForm.php on line 13

Seems like that PHP error is from the following:

+++ b/src/Form/QuicklinkConfigForm.php
@@ -4,12 +4,44 @@ namespace Drupal\quicklink\Form;
+  public static function create(ContainerInterface $container) {

You need to add a use statement along with the others at the top of this class to let PHP know where to find the right ContainerInterface interface, eg. use Symfony\Component\DependencyInjection\ContainerInterface;

Please review!

@i-trokhanenko Thanks for this! I'll test this and review it by early next week.

When extending ConfigFormBase it's not necessary to inject ConfigFactoryInterface. You can just do

$config = $this->config('your_module.settings');

In this patch, it doesn't look like it's even using configuration.

This looks good to me, with the minor comment below:

+++ b/src/Form/QuicklinkConfigForm.php
@@ -11,6 +14,36 @@ use Drupal\Core\Form\FormStateInterface;
+   * Constructs a \Drupal\system\ConfigFormBase object.

Nitpick: We could update this line to be accurate to the object we are creating here.

When extending ConfigFormBase it's not necessary to inject ConfigFactoryInterface

True, however this patch overrides the constructor, and in order to be able to call the parent's contructor, we need the config factory available, so I guess it's OK as it stands, on this regard.

Good point @marcoscano. I concur.

OK. Updated patches below based on comments from @marcoscano and a quick hangout w @mtift

👍 Looks good to me!

Woot! Committed. Thanks everyone :)