Edit button by users without access (includes refactors to list and access control)

1. +++ b/monitoring.module
   @@ -4,14 +4,45 @@
   +/**
   + * Implements hook_entity_operation().
   + */
   +function monitoring_entity_operation(EntityInterface $entity) {
   +  if (!$entity instanceof SensorConfigInterface) {
   +    return [];
   +  }
   +
   

   Lets add this to getDefaultOperations() in SensorListBuilder instead, we don't need to add a hook for own entity type.

2. +++ b/src/Controller/SensorList.php
   @@ -107,30 +108,19 @@ class SensorList extends ControllerBase {
    
   -        \Drupal::moduleHandler()->alter('monitoring_sensor_links', $links, $sensor_config);
   +        // @todo deprecate, same can be achieved with \hook_entity_operation().
   +        \Drupal::moduleHandler()->alter('monitoring_sensor_links', $operations, $sensor_config);
   

   Fine we deprecating that right now, we can use alterDeprecated for it.

3. +++ b/src/SensorConfigAccessControlHandler.php
   @@ -26,17 +27,27 @@ class SensorConfigAccessControlHandler extends EntityAccessControlHandler {
   +
   +      // We're testing against permission, so add vary by permission.
   +      $cacheability->addCacheContexts(['user.permissions']);
   +      if ($account->hasPermission('monitoring reports')) {
   +        return AccessResult::allowed();
   

   you don't actually add $cacheability to the returned access result here.

Reroll + #7

MR needs rebasing.

Rebased.

Rebased again, this conflicted with a destination fix for the edit link. This would have been already fixed if we were already using operations so it would be great to get this one in!

The fixes look good to me.
I confirm that all 3 changes requested by @berdir have been addressed.
I tested on my project running on Drupal core 11.3.12 and didn't notice any issues.
Good for RTBC

Looks, one comment on the operations method.

Replied, I already tried adding the parameter without being commented out.

Thanks, merged!