The large serialized data in TestRestClient is confusing git, and terrible for version control.

Move it out of the PHP file.

CommentFileSizeAuthor
#8 salesforce-binary_data_cleanup-3039443-8.patch352.83 KBaaronbauman
#6 salesforce-binary_data_cleanup-3039443-6.patch345.21 KBaaronbauman
#4 salesforce-binary_data_cleanup-3039443-4.patch344.71 KBaaronbauman
#2 salesforce-binary_data_cleanup-3039443.patch344.64 KBaaronbauman

Comments

AaronBauman created an issue. See original summary.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Active » Needs review
StatusFileSize
new salesforce-binary_data_cleanup-3039443.patch344.64 KB

Status: Needs review » Needs work

The last submitted patch, 2: salesforce-binary_data_cleanup-3039443.patch, failed testing. View results

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new salesforce-binary_data_cleanup-3039443-4.patch344.71 KB

Fix array/object issues

Status: Needs review » Needs work

The last submitted patch, 4: salesforce-binary_data_cleanup-3039443-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new salesforce-binary_data_cleanup-3039443-6.patch345.21 KB

Status: Needs review » Needs work

The last submitted patch, 6: salesforce-binary_data_cleanup-3039443-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new salesforce-binary_data_cleanup-3039443-8.patch352.83 KB

  • AaronBauman committed ba64ea9 on 8.x-3.x 
    Issue #3039443 by AaronBauman: Clean up "binary" looking data from tests
aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs review » Fixed

  • AaronBauman committed ba64ea9 on 8.x-4.x 
    Issue #3039443 by AaronBauman: Clean up "binary" looking data from tests

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.