https://www.drupal.org/pift-ci-job/1225437
https://www.drupal.org/pift-ci-job/1225444

MySQL 5.7 is passing.

CommentFileSizeAuthor
#10 3039274-10.patch6.43 KBbojanz
#5 commerce-3039274-postgresql-5.patch2.95 KBczigor
#4 mysql.png85.4 KBczigor
#4 postgresql.png88.61 KBczigor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Title: MultipleCartMultipleVariationTypesTest is failing on MySQL 8 » MultipleCartMultipleVariationTypesTest is failing on MySQL 8 and PostgreSQL 9.1
Issue summary: View changes
czigor’s picture

czigor CreditAttribution: czigor at Centarro commented

I can reproduce the failure with PostgreSQL 11.

czigor’s picture

czigor CreditAttribution: czigor at Centarro commented
FileSize
postgresql.png88.61 KB
mysql.png85.4 KB

The issue is that mysql and postgresql sorts the strings "My Colors & Sizes - FIRST" and "My Colors - FIRST" differently. See the two attached screenshots, one made with postgreSQL, the other with MySQL.

Let's rename the products so that sorting is not ambiguous.

czigor’s picture

czigor CreditAttribution: czigor at Centarro commented
Status: Active » Needs review
FileSize
commerce-3039274-postgresql-5.patch2.95 KB

This passes locally.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Needs work

We should then apply the same naming pattern in other cases too (I believe there is a SECOND after a FIRST).

czigor’s picture

czigor CreditAttribution: czigor at Centarro commented

What do you mean? FIRST is supposed to be referring to the place in the list? (We had 3 FIRST products.)

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

Nevermind, I was looking at the wrong test.

We have a MultipleCartMultipleVariationTypesTest functional test and a MultipleCartMultipleVariationTypesTest functional javascript test. Having them named the same is... confusing.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs work » Needs review
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
FileSize
3039274-10.patch6.43 KB

Modified the other test to match as well.

  • bojanz committed 9ccd9fb on 8.x-2.x authored by czigor 
    Issue #3039274 by czigor, bojanz: MultipleCartMultipleVariationTypesTest...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Committed. Thanks, Andras!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.