The HTML markup and classes for the Big, Medium & Slim footers have changed quite a bit in the v2 version of the standards.
Compare v1: https://designsystem.digital.gov/components/footers/ with
v2: https://v2.designsystem.digital.gov/components/footers/

We'll need to update the templates & preprocess functions to reflect these new updates.

CommentFileSizeAuthor
#3 fix_footer-3038999-3.patch1.8 KBrromore

Comments

Irisibk created an issue. See original summary.

irisibk’s picture

irisibk commented
Issue summary: View changes
rromore’s picture

rromore commented
StatusFileSize
new fix_footer-3038999-3.patch1.8 KB

I believe most of this was done in https://www.drupal.org/project/uswds/issues/3039824, however I did see a few small issues that I think were missed which are applicable to this ticket. I'm attaching a patch which does the following:

- changes `$variables['footer_style']` in page.preprocess.inc to use 'usa-footer--' instead of 'usa-footer-'
- changes the footer helpful flags variables to compare against `$footer_style` instead of `$variables['footer_style']`, which is more in line with what the header helpful flags variables are using
- changes footer nav element's class from "usa-footer-nav" to "usa-footer__nav" in templates/system/layout/page.html.twig

irisibk’s picture

irisibk commented
Status: Active » Needs review
fskreuz’s picture

fskreuz commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • Irisibk committed 262668f on 8.x-2.x authored by rromore 
    Issue #3038999 by rromore: Update Footer markup & classes
irisibk’s picture

irisibk commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.