Hello,

The 6.16 Configuring Text Formats and Editors section aims to add a horizontal rule tag to the Basic HTML text format. Here is the 6th step to achieve this goal:

Under Filter settings > Limit allowed HTML tags and correct faulty HTML, in the field Allowed HTML tags, add<hr>to what is already present.

Using Drupal 8.6.10, this step is not required anymore because the<hr>tag is automatically added to the Allowed HTML tags of the Filter settings when you drag the horizontal rule button (or other buttons such as table or underline, for instance) from Available buttons to Tools under Active toolbar.

Regards,

Gilles

CommentFileSizeAuthor
#18 D8SB.png22.94 KBgillesbailleux
#5 3038305-5.patch740 bytesjhodgdon
#3 3038305.patch742 bytesjhodgdon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gillesbailleux created an issue. See original summary.

jhodgdon’s picture

Thanks for this issue too! We'll get it fixed soon.

jhodgdon’s picture

Status: Active » Needs review
FileSize
742 bytes

How's this patch?

gillesbailleux’s picture

@jhodgdon: because I am being asked to become Acquia Certified Site Builder, I have to read the Drupal 8 User Guide. It is a true pleasure to take time to discover the work of the Documentation team, either for its content but also for the challenge that it represents: writing technological guidelines for an audience which is presumed to be non technical is rather a matter of communication than a question of technical expertise. The Documentation team has fortunatley members with both qualities, for instance Boris Doesborg (whom I have not seen for ages) who has achieved a tremendous work.

Back to this issue: because the tags are automatically added, the use of the future sense is preferred to the conditional tense. I suggest the following sentence: "adding its editor button will automatically update the allowed tags".

jhodgdon’s picture

FileSize
740 bytes

Good idea, thanks! Here's a new patch. I didn't make an interdiff, as it's a 2-line patch anyway.

eojthebrave’s picture

Status: Needs review » Fixed

Looks good to me. Thanks @gillesbailleux for point out the issue, and @jhodgdon for helping to get it fixed.

I'll commit this now. And, we'll want to notify the translation teams about this change.

  • eojthebrave committed 7bf7d47 on 8.x-6.x authored by jhodgdon
    Issue #3038305 by jhodgdon, gillesbailleux: CKEditor Available buttons...

  • eojthebrave committed 7bf7d47 on 8.x-6.x authored by jhodgdon
    Issue #3038305 by jhodgdon, gillesbailleux: CKEditor Available buttons...

  • eojthebrave committed 7bf7d47 on 8.x-6.x authored by jhodgdon
    Issue #3038305 by jhodgdon, gillesbailleux: CKEditor Available buttons...

  • eojthebrave committed 7bf7d47 on 8.x-6.x authored by jhodgdon
    Issue #3038305 by jhodgdon, gillesbailleux: CKEditor Available buttons...

  • eojthebrave committed 7bf7d47 on 8.x-6.x authored by jhodgdon
    Issue #3038305 by jhodgdon, gillesbailleux: CKEditor Available buttons...

  • eojthebrave committed 7bf7d47 on 8.x-6.x authored by jhodgdon
    Issue #3038305 by jhodgdon, gillesbailleux: CKEditor Available buttons...

  • eojthebrave committed 7bf7d47 on 8.x-6.x authored by jhodgdon
    Issue #3038305 by jhodgdon, gillesbailleux: CKEditor Available buttons...

  • eojthebrave committed 7bf7d47 on 8.x-6.x authored by jhodgdon
    Issue #3038305 by jhodgdon, gillesbailleux: CKEditor Available buttons...

  • eojthebrave committed 7bf7d47 on 8.x-6.x authored by jhodgdon
    Issue #3038305 by jhodgdon, gillesbailleux: CKEditor Available buttons...

  • eojthebrave committed 7bf7d47 on 8.x-6.x authored by jhodgdon
    Issue #3038305 by jhodgdon, gillesbailleux: CKEditor Available buttons...
jhodgdon’s picture

I'm sending information to the group email list now.

gillesbailleux’s picture

FileSize
22.94 KB

@jhodgdon: just a word to tell you that I passed the certification and that I shall continue to contribute to the User Guide.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.