Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
When submitting the configuration form at admin/config/content/entity_browser/FOOBAR/edit or admin/config/content/entity_browser/FOOBAR/widgets, no confirmation message appears. A minor but still.
Proposed resolution
Add a message that confirms that settings were changed.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#19 | entity-browser-remove-duplicate-trait-3038292-19.patch | 491 bytes | oknate |
#12 | entity-browser-confirmation-message-3038292-11.patch | 19.24 KB | oknate |
#11 | entity-browser-confirmation-message-3038292-11.patch | 19.24 KB | oknate |
#11 | 3038292-interdiff--9-11.txt | 915 bytes | oknate |
#9 | entity-browser-confirmation-message-3038292-9.patch | 19.83 KB | oknate |
Comments
Comment #2
oknateComment #3
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedThanks. Maybe we could use the messenger service, given that it's already available in entity forms.
Comment #4
oknateHere are three patches that use the messenger service.
1) First one just uses messenger trait, which will call \Drupal::messenger()
2) Second one injects messenger service into the two forms
3) Third one replaces drupal_set_message() throughout the entity_browser module.
Comment #6
oknateFixing v3.
Comment #7
oknateReroll of #6 after #3033289: Remove unused constructor argument in EntityReferenceBrowserWidget
Comment #8
oknateAdding test coverage.
Comment #9
oknateReroll
Comment #10
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedSeems unrelated?
Apart from that seems quite ok to me. Tested this manually, worked quite alright.
Comment #11
oknateUpdated.
Comment #12
oknateRunning test against 8.x-1.x branch.
Comment #13
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedComment #16
oknateCommitted. Thanks for the idea/review, Primsi.
Comment #17
oknateComment #18
oknateLooks like I introduced a minor bug:
https://www.drupal.org/pift-ci-job/1234548
FormBase already has MessengerTrait.
Comment #19
oknateComment #20
Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commentedGood catch.
Comment #23
oknate