The capitalization is not very consistent and does not follow Drupal's standard.

Need to standardize it.

CommentFileSizeAuthor
#6 performance_install.patch6.88 KBjcmarco
#6 performance_module.patch6.54 KBjcmarco
#3 performance_module_coder.patch7.48 KBjcmarco
#3 performance_install_coder.patch4.36 KBjcmarco

Comments

kbahey’s picture

kbahey commented
Project: Performance Logging and Monitoring (D7) » Devel
Version: 5.x-1.x-dev » 6.x-1.x-dev
Component: User interface » performance

Moving to devel queue, since the module is now part of that.

moshe weitzman’s picture

moshe weitzman commented

I welcome patches for coding standards.

jcmarco’s picture

jcmarco commented
Status: Active » Needs review
StatusFileSize
new performance_install_coder.patch4.36 KB
new performance_module_coder.patch7.48 KB

Using Coder

moshe weitzman’s picture

moshe weitzman commented

@kbahey - look OK to you?

kbahey’s picture

kbahey commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

jcmarco, thank you. I committed it for 6.x.

Can you be so kind as to download 7.x-1.x-dev tomorrow (because I just committed a change that will be packaged in about 9 hours from now) and do the same for it and submit a patch?

jcmarco’s picture

jcmarco commented
StatusFileSize
new performance_module.patch6.54 KB
new performance_install.patch6.88 KB

Checked with last coder 7.x-dev

performance.install:
practically the same with just a correction in @file

performance.module:
added a recommendation for new drupal_module_exist.
I haven't changed the time() recommendation as I guess that it is necessary accuracy with timings.

jcmarco’s picture

jcmarco commented
Status: Patch (to be ported) » Needs review
kbahey’s picture

kbahey commented
Status: Needs review » Fixed

thanks you!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mycat’s picture

mycat commented
Title: Capitalization needs to follow Drupal's standard » display problem "devel_themer_ie_fix.css"
Version: 7.x-1.x-dev » 6.x-1.8
Component: performance » devel_themer
Status: Closed (fixed) » Active
Issue tags: +devel themer info is not bottom in IE

first, sorry for my english.

in the devel-module, in devel_themer_ie_fix.css is an little error.

original Code (:

#themer-toggle {
  position: absolute !important;
  top: 0 !important;
  bottom: auto !important;
}

This text has also effect: "Themer Info" is not formatted as "bottom" ...
And: with absolute position the "Themer Info" is scrolling with the Layout.

must be:

#themer-toggle {
  position: fixed !important;
  top: auto !important;
  bottom: 0 !important;
}

fixed: "Themer Info" is too in IE always bottom!
With position fixed the "Themer Info" do not scroll with the Layout!

Thanks an greetings

Fredi

P.S. i hope, this is the right place for this message.

jcmarco’s picture

jcmarco commented

Probably, the best would be to open a new issue

moshe weitzman’s picture

moshe weitzman commented
Status: Active » Closed (fixed)