The document outline expects an H2, not an H4 for status-messages, as everything else is H2.

CommentFileSizeAuthor
#6 3037935-status_msgs_outline-6.patch819 bytesytsurk
#5 3033775-chrome_sticky_compability-5.patch1.01 KBytsurk
#2 3037935-status_msgs_outline-2.patch819 bytesytsurk

Comments

ytsurk created an issue. See original summary.

ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new 3037935-status_msgs_outline-2.patch819 bytes
pivica’s picture

pivica commented
Status: Needs review » Reviewed & tested by the community

Makes total sense i guess. Tagging for merging for next point release.

Regarding the invisible h1 tags in header and footer main sections of the page so the generated outline of the page is more structured that also make sense but i can't really help with that because i have no idea how end users are really using outlines with their tools, so i am afraid i can't help here a lot. Can we find some research or use case that is backing this other change?

pivica’s picture

pivica commented
Issue tags: +next-point-release-merge
ytsurk’s picture

ytsurk
Location Switzerland
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3033775-chrome_sticky_compability-5.patch1.01 KB

Sorry - H2 is even more accurate ..

I removed the further improvement statements, it's quite philosophical .. Leave as is for now.

ytsurk’s picture

ytsurk
Location Switzerland
commented
StatusFileSize
new 3037935-status_msgs_outline-6.patch819 bytes
pivica’s picture

pivica commented
Status: Needs review » Reviewed & tested by the community

h2 fine by me, we anyway do not show it by default :)

pivica’s picture

pivica commented
Title: Uplift status-message visually hidden heading from H4 to H3 » Uplift status-message visually hidden heading from H4 to H2

  • pivica committed 91fa173 on 8.x-1.x authored by ytsurk 
    Issue #3037935 by ytsurk: Uplift status-message visually hidden heading...
pivica’s picture

pivica commented
Status: Reviewed & tested by the community » Fixed

Committed.

pivica’s picture

pivica commented
Issue tags: -next-point-release-merge

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.