Theme settings not fully defined or styled properly

Hello!

The schema config for the bootstrap_barrio_library is set as integer when it must be a string. The option is never saved in the settings form.

Besides, the whole functionality is redundant. It basically replicates the attachment process of the library to the page which is also handled in the bootstrap_library module.
The configurations for the theme and the module will almost always contradict each other(if you define the local library and set the theme to use the local one and at the same time you use bootstrap_library module CDN functionality, you will end up with double libraries).

I think it's necessary to define conditional requirements for this theme:

• When bootstrap_library module is present, pass on the requirements to it(unless CDN option is defined, check for presence of a local bootstrap library).
• When bootstrap_library module is not installed, define the need for a local bootstrap library.

I would really appreciate an input about this and as soon as we settle some "if's" here, we can also bug the maintainers from bootstrap_library about this.

The thing is: this theme has to be forced to accept whatever bootstrap_library is set to use as the delivery method, when the module is enabled of course.

As it is now, it is really misleading and should I mention wrong?

Overall it is a different issue, but a small part of it is still related to the schema and theme settings.

The attached patch is a re-roll of #3 that applies cleanly to version 8.x-4.22 for anyone who needs to apply this patch directly to that released version.

>>set as integer when it must be a string

I already have a patch for one serious issue caused by schema settings that are the wrong type.

#2977160: Missing Navbar on mobile due to incorrect values in schema file

There seems to be no active maintainer for this theme. Neither this issue nor the issue I made a patch for have received any response from the maintainer. The last commit was back in February - 8 months ago.

Hello,
The theme is mantained and most requests responded in between 24 hours.
Documentation updated.
This is personal effort on spare time.
Whenever the direction of a patch is not perceived as in the right direction it is pointed out.
A new release should come, but it requires a lot of time and responsibility from my side as thousands of sites could crush of not verified on full detail.
If you wish to contribute testing the patches more than happy to receive your help.
Regards

@joegraduate
Patch failed on DEV, could not apply yet.

@hatuhay the patch in #12 is not intended to be applied to dev. I uploaded it for the convenience of anyone needing to apply the patch to the 4.22 version, specifically.

I believe the original patch in #3 should still apply to the dev branch.

» 7.x-4.22 should be » 8.x-4.22

Can't delete files so have to add a new comment with the correct version number. 8.x-4.22

Thanks @trackleft2 for incorporating the D9 deprecation fixes from #3069680: Drupal 9 Deprecated Code Report here! We needed a way to apply both the fixes from that issue as well as this one in our build and your patches helped us do that.

We are now using the patch in #22 in our composer build because it applies cleanly to the tarball version of 8.x-4.22.

The attached patch is a re-roll of #20 / #22 that applies cleanly to the latest 8.x-4.x dev branch.

(Also restored original issue summary).