Problem/Motivation

The problem is in `_bs_base_generate_file()`. We have a `foreach` that is using the reference variable `&$library`. Then lower in code, some other `foreach` is using the same variable name `$library` effectively overriding the last element from previous `foreach`.

Proposed resolution

Rename `$library` variable name in a second `foreach`.

CommentFileSizeAuthor
#2 drush-generator-bug-3037650-2.patch1.28 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Status: Active » Needs review
StatusFileSize
new drush-generator-bug-3037650-2.patch1.28 KB

Here is a patch.

pivica’s picture

pivica commented

For the themes that are already generated manually edit info.yml file of generated theme and make sure to change:

  bs_bootstrap/navbar-second-level-horizontal:
    css:
      layout:
        css/components/extlink.css: css/components/extlink.css

to

  bs_bootstrap/navbar-second-level-horizontal:
    css:
      component:
        /.../css/components/navbar-second-level-horizontal.css: css/components/navbar-second-level-horizontal.css

Adjust `/.../css/components/navbar-second-level-horizontal.css` to your parent path theme.

pivica’s picture

pivica commented
Issue tags: +next-point-release-merge

  • pivica committed e45682d on 8.x-1.x 
    Issue #3037650 by pivica: Drush generator is buggy when adding override...
pivica’s picture

pivica commented
Status: Needs review » Fixed
Issue tags: -next-point-release-merge

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.