Decorate JSON:API's normalizers and fake its namespace so JSON:API can eliminate its Serializer's fallback behavior.

Wow, really impressive work here!

Of course, the person to review this, is @e0ipso.

1. +++ b/jsonapi_extras.services.yml
   @@ -1,39 +1,33 @@
   +    decorates: serializer.normalizer.field_item.jsonapi
   ...
   +    decorates: serializer.normalizer.resource_identifier.jsonapi
   

   👏 Decoration FTW!

2. +++ b/src/JsonapiExtrasServiceProvider.php
   @@ -28,37 +28,21 @@ class JsonapiExtrasServiceProvider extends ServiceProviderBase {
   +    // Enable normalizers in the "src-impostor-normalizers" directory to be
   +    // within the \Drupal\jsonapi\Normalizer namespace in order to circumvent
   +    // the encapsulation enforced by
   +    // \Drupal\jsonapi\Serializer\Serializer::__construct().
   +    $container_namespaces = $container->getParameter('container.namespaces');
   +    $container_modules = $container->getParameter('container.modules');
   +    $container_namespaces['Drupal\jsonapi\Normalizer\ImpostorFrom\jsonapi_extras'][] = dirname($container_modules['jsonapi_extras']['pathname']) . '/src-impostor-normalizers';
   +    $container->setParameter('container.namespaces', $container_namespaces);
   

   😮 → 🤔 → 🥳

3. +++ b/src/Normalizer/JsonApiNormalizerDecoratorBase.php
   similarity index 50%
   rename from src/Normalizer/RelationshipItemNormalizer.php
   
   rename from src/Normalizer/RelationshipItemNormalizer.php
   rename to src/Normalizer/ResourceIdentifierNormalizer.php
   

   This rename should've already happened before, it just hasn't yet. No huge deal, but if you don't know that this is simply a "forgotten rename", then this is of course very confusing.

+++ b/src/JsonapiExtrasServiceProvider.php
@@ -28,37 +28,21 @@ class JsonapiExtrasServiceProvider extends ServiceProviderBase {
+    $container_namespaces['Drupal\jsonapi\Normalizer\ImpostorFrom\jsonapi_extras'][] = dirname($container_modules['jsonapi_extras']['pathname']) . '/src-impostor-normalizers';

I think we can remove the [] from here. It's a remnant from earlier work that I did on this where I was adding to the Drupal\jsonapi namespace rather than defining a more specific namespace.

I'll be looking into this soon.

This is a neat trick! I don't see any big issues that prevent from merging, then refining if necessary.

However, it makes me doubt the effectiveness of the prevention measures we put in JSON:API. I think this all rely on hopefully people won't notice that you can do it like this.

I will re-roll de patch and then merge.

Kicking tests. No interdiff because re-roll.

There's two failures in #8:

1. ::testWrite() fails because as of JSON:API 2.4, "read-only mode" is turned on by default: #3039568: Add a read-only mode to JSON:API
2. jsonapi.link_manager no longer exists.

Attached is the fix for the first failure. For the second failure, we should commit #3035045: Make EntityToJsonApi use subrequests so that it never breaks again. Marking this issue as postponed on that.

#3035045: Make EntityToJsonApi use subrequests so that it never breaks again is resolved. Un-postponing and kicking off tests.

I think we want #3035134: Compatibility with upcoming JSON:API 2.4 release: JSON:API Extras 3.5 to land first.

Applied #10 on top of #3042124-11: [regression] Empty response body when user is an administrator and an exception is thrown; some traces cannot be encoded because of recursion detection. — tests are green :) As soon as that lands, this can move forward too. 🥳

#3035134: Compatibility with upcoming JSON:API 2.4 release: JSON:API Extras 3.5 landed. Uploading a rebased #10.

You beat me to it @Wim Leers!

@Wim Leers++

Fixed! Thanks all.