Problem/Motivation

Deprecated Unicode::strlen() need to be replaced

Proposed resolution

Use mb_strlen() According to https://www.drupal.org/node/2850048

CommentFileSizeAuthor
#3 entity-embed-unicode-3036034-3.patch823 bytesoknate
#2 deprecated_unicode_removed-3036034-2.patch575 bytesakshay_d

Comments

akshay_d created an issue. See original summary.

akshay_d’s picture

akshay_d
Location Bangalore
commented
Status: Active » Needs review
StatusFileSize
new deprecated_unicode_removed-3036034-2.patch575 bytes

removed deprecated method please review

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-embed-unicode-3036034-3.patch823 bytes

The use statement also needs to be removed.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Coding standards, +Drupal 9

Looks good, thanks both of you! 👍

  • Wim Leers committed e373430 on 8.x-1.x authored by akshay_d 
    Issue #3036034 by akshay_d, oknate, Wim Leers: Deprecated Unicode::...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

I also verified that no other uses of Drupal\Component\Utility\Unicode remain in the Entity Embed module after this patch. 👍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: -Drupal 9 +Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.