When viewing the file usages page at file/%/usage, frequently the data presented is not entirely accurate, and is missing some information (like the entity ID) that I find important.
So, I got in there and fixed things up so the incorrect and/or missing information was available.
The patch is forthcoming.

CommentFileSizeAuthor
#3 file_entity-improve_file_usages_page-3035985-3.patch2.85 KBoadaeh
#7 interdiff-3035985-3-7.txt592 bytesoadaeh
#7 file_entity-improve_file_usages_page-3035985-7.patch3.48 KBoadaeh

Comments

oadaeh created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Awesome, please upload the patch!
Looking forward to seeing the patch.

oadaeh’s picture

oadaeh commented
Assigned: oadaeh » Unassigned
Status: Active » Needs review
StatusFileSize
new file_entity-improve_file_usages_page-3035985-3.patch2.85 KB

Attached is the patch.
These are the changes included in it:

  • Modifying some of the header labels to more clearly state what data is being displayed
  • Modifying the entity label to indicate the state of the entity or entity label load, rather than printing the module name or nothing at all, if no label was selected
  • Modifying the link to the entity to include the link options, when they existed
  • Adding an Entity ID column

Status: Needs review » Needs work

The last submitted patch, 3: file_entity-improve_file_usages_page-3035985-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

oadaeh’s picture

oadaeh commented
Assigned: Unassigned » oadaeh

Okay, I guess I need to update a test or two.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

cool ya looks great, just need to update the file usage test.

oadaeh’s picture

oadaeh commented
Assigned: oadaeh » Unassigned
Status: Needs work » Needs review
StatusFileSize
new file_entity-improve_file_usages_page-3035985-7.patch3.48 KB
new interdiff-3035985-3-7.txt592 bytes

New patch with updated test and interdiff attached.

jstoller’s picture

jstoller
he/him
commented
Status: Needs review » Reviewed & tested by the community

Patch still applies and works as advertised.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Thanks jstoller and oadaeh!

this is in the dev branch, it will make it into the next release (whenever that is).

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.