I have a need to unflag all entities flagged by a user, using a specific flag. The flagging service has an unflagAllByUser() method and an unflagAllByFlag() method, but not the combo. Patch incoming.

CommentFileSizeAuthor
#2 flag-unflagAllByFlagByUser-3034896-2.patch1.97 KBjohnny5th

Issue fork flag-3034896

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

johnny5th created an issue. See original summary.

johnny5th’s picture

johnny5th commented
StatusFileSize
new flag-unflagAllByFlagByUser-3034896-2.patch1.97 KB
ivnish’s picture

ivnish
he/him
commented
Status: Active » Needs work
Issue tags: +Needs reroll, +Needs tests
ivnish’s picture

ivnish
he/him
commented
Version: 8.x-4.x-dev » 5.x-dev

ivnish opened merge request !179

ivnish’s picture

ivnish
he/him
commented
Category: Feature request » Task

deaom made their first commit to this issue’s fork.

deaom’s picture

deaom commented
Status: Needs work » Needs review

The tests are actually passing, the issue is with previous version of composer in the gitlab-ci template #3564269: Composer 2.9 blocks dependencies which have security advisories. It can be ignored, so removed from the gitlab-ci for this project or simply ignored till the issue is fixed. Up to maintainers to decide, but marking the issue as needs review as the patch was applied and test was added.

ivnish’s picture

ivnish
he/him
commented
Issue tags: -Needs reroll, -Needs tests

  • ivnish committed 88e93bb5 on 5.x 
    feat: #3034896 FlagService - unflagAllByUserByFlag

By: johnny5th
By:...
ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.