The settings of the feature "Marker Icon Adjustment" have no effect when using geolocation_google_maps. I can see the settings being available in geolocation-marker-icon.js, but the callback for marker_icon in "Drupal.geolocation.executeFeatureOnAllMaps" never gets fired.
Additionally (and I understand very little of the design of this module) geolocation-google-maps.js deals with the marker_icon_path setting, but uses the wrong configuration keys. I've applied a patch that fixes that mismatch, resulting in at least the marker icon being shown.
Any guidance in how to help resolve the issue is appreciated!
Comments
Comment #2
christianadamski commentedGood point. This shoud move to the MapFeatue instead if possible
Comment #3
christianadamski commentedComment #4
christianadamski commentedComment #5
jsst commentedI believe you've related the wrong issue here :)
Comment #6
jacobbell84 commentedI think this was a symptom of a larger problem. Looks like the architecture had changed at some point and the google maps marker related scripts never got updated. The fix seems to be binding the marker code to addPopulatedCallback in addition to addMarkerAddedCallback. The script also had a couple typos that were causing issues. This patch, combined with jsst's patch, has fixed the issues for me.
Comment #7
christianadamski commentedThe larger issue is fixed. Now this patch therefor is slightly off.
Comment #8
christianadamski commentedThe jsst patch is incorrect. Kinda. The issue is you can add the icon path in two very different ways:
- either hardcoded through this MapIcon Feature
or
- Through the views style by using a views image field
So the code is correct and the way it is meant to be. Instead, the feature has to decide, whether it overrides a given IconURL or not.
Comment #9
christianadamski commentedHere is an adjusted patch
Comment #11
christianadamski commentedThanks for testing and all the work!
Comment #13
jacobbell84 commented