Closed (fixed)
Project:
Nothing
Version:
8.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Feb 2019 at 14:37 UTC
Updated:
30 Jun 2020 at 16:43 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dennis cohn commentedProvided the patch to remove the help page hook as defined in nothing.module
Comment #3
askibinski commentedDon't we need a test to see if this module really doesn't do anything?
Comment #4
BarisW commentedThis should be critical for sure
Comment #5
seanbI think testing nothing with nothing would be the best solution here.
Comment #6
kmajzlik commentedDo we need nothing.module file? I think that in Drupal 8 .info.yml should be all we need.
Comment #7
thejimbirch commentedThe defined "This module never will do nothing" is a double negative.
In standard English, two negatives cancel each other out, so this module description is actually saying it will do something.
Comment #8
tedbowActually I believe
The module description here is saying in no case, never, will the module do nothing.
But since the only hook this module is implementing,
hook_help, is provided by the help module if the help module is not enabled this module will do nothing.So in the case that help module is not enabled this module will do nothing. So hardly "never"
Furthermore a site could have the help module enabled but the route
help.pagecould be altered in any number of ways to not do anything if the route argument{name}equals "nothing". So this case the module would also do nothing.You could even argue that on most sites nobody ever goes to the
/admin/helppath so nobody would ever see the "Nothing" link to look on at the message. So in that case since this modules message was never printed on the screen the module never does anything.Comment #9
yuseferi commentedComment #10
yuseferi commentedComment #11
yuseferi commentedComment #12
yuseferi commentedComment #13
pepijn-ezcompany commentedIn this case, should the issue not be marked as "Closed (Won't fix)"?
Since the issue reported was basically denied in #7 and #8, and thus will not be fixed instead of has been fixed?