While the module states it does nothing, the module actually does something, namely displaying text on a help page.
As the module is described as "This module never will do nothing", I believe it's unacceptable that, with the given description, it actually shows text while instead it should do nothing at all as described.

I suggest to remove the help page hook as defined in nothing.module, or remove the nothing.module file in its entirety as this isn't a requirement for a module.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pepijn-ezcompany created an issue. See original summary.

Dennis Cohn’s picture

Provided the patch to remove the help page hook as defined in nothing.module

askibinski’s picture

Issue tags: +Needs tests

Don't we need a test to see if this module really doesn't do anything?

BarisW’s picture

Priority: Major » Critical

This should be critical for sure

seanB’s picture

Status: Active » Reviewed & tested by the community
Issue tags: -Needs tests

I think testing nothing with nothing would be the best solution here.

kmajzlik’s picture

Do we need nothing.module file? I think that in Drupal 8 .info.yml should be all we need.

thejimbirch’s picture

Status: Reviewed & tested by the community » Needs review

The defined "This module never will do nothing" is a double negative.

In standard English, two negatives cancel each other out, so this module description is actually saying it will do something.

tedbow’s picture

Status: Needs review » Needs work

Actually I believe

"This module never will do nothing"

The module description here is saying in no case, never, will the module do nothing.

But since the only hook this module is implementing, hook_help, is provided by the help module if the help module is not enabled this module will do nothing.

So in the case that help module is not enabled this module will do nothing. So hardly "never"

Furthermore a site could have the help module enabled but the route help.page could be altered in any number of ways to not do anything if the route argument {name} equals "nothing". So this case the module would also do nothing.

You could even argue that on most sites nobody ever goes to the /admin/help path so nobody would ever see the "Nothing" link to look on at the message. So in that case since this modules message was never printed on the screen the module never does anything.

yuseferi’s picture

yuseferi’s picture

Status: Needs work » Fixed
yuseferi’s picture

yuseferi’s picture

Status: Fixed » Closed (fixed)
pepijn-ezcompany’s picture

In this case, should the issue not be marked as "Closed (Won't fix)"?
Since the issue reported was basically denied in #7 and #8, and thus will not be fixed instead of has been fixed?