Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
While the module states it does nothing, the module actually does something, namely displaying text on a help page.
As the module is described as "This module never will do nothing", I believe it's unacceptable that, with the given description, it actually shows text while instead it should do nothing at all as described.
I suggest to remove the help page hook as defined in nothing.module, or remove the nothing.module file in its entirety as this isn't a requirement for a module.
Comment | File | Size | Author |
---|---|---|---|
#2 | this_module_actually_does_something-3034791-2.patch | 649 bytes | Dennis Cohn |
Comments
Comment #2
Dennis Cohn CreditAttribution: Dennis Cohn commentedProvided the patch to remove the help page hook as defined in nothing.module
Comment #3
askibinski CreditAttribution: askibinski commentedDon't we need a test to see if this module really doesn't do anything?
Comment #4
BarisW CreditAttribution: BarisW at LimoenGroen for KRO-NCRV commentedThis should be critical for sure
Comment #5
seanBI think testing nothing with nothing would be the best solution here.
Comment #6
kmajzlik CreditAttribution: kmajzlik at Ciklum Western Europe for BurdaForward commentedDo we need nothing.module file? I think that in Drupal 8 .info.yml should be all we need.
Comment #7
thejimbirch CreditAttribution: thejimbirch at Kanopi Studios commentedThe defined "This module never will do nothing" is a double negative.
In standard English, two negatives cancel each other out, so this module description is actually saying it will do something.
Comment #8
tedbowActually I believe
The module description here is saying in no case, never, will the module do nothing.
But since the only hook this module is implementing,
hook_help
, is provided by the help module if the help module is not enabled this module will do nothing.So in the case that help module is not enabled this module will do nothing. So hardly "never"
Furthermore a site could have the help module enabled but the route
help.page
could be altered in any number of ways to not do anything if the route argument{name}
equals "nothing". So this case the module would also do nothing.You could even argue that on most sites nobody ever goes to the
/admin/help
path so nobody would ever see the "Nothing" link to look on at the message. So in that case since this modules message was never printed on the screen the module never does anything.Comment #9
yuseferi CreditAttribution: yuseferi commentedComment #10
yuseferi CreditAttribution: yuseferi commentedComment #11
yuseferi CreditAttribution: yuseferi commentedComment #12
yuseferi CreditAttribution: yuseferi commentedComment #13
pepijn-ezcompany CreditAttribution: pepijn-ezcompany at ezCompany commentedIn this case, should the issue not be marked as "Closed (Won't fix)"?
Since the issue reported was basically denied in #7 and #8, and thus will not be fixed instead of has been fixed?