Problem/Motivation

Remove calls to deprecated method assertIdentical() and replace with assertSame()

Change records:
https://www.drupal.org/node/2469723

CommentFileSizeAuthor
#8 interdiff_6-8.txt26.29 KBamarphule
#8 remove-calls-to-deprecated-method-assertIdentical-replace-asserSame-3034762-8.patch26.92 KBamarphule
#6 interdiff-3034762-2-6.txt2.09 KBthalles
#6 pathauto-Remove-calls-to-deprecated-method-assertIdentical-3034762-6-D8.patch2.3 KBthalles
#2 Remove-calls-to-deprecated-method-assertIdentical-3034762-2.patch2.32 KBshruthi_shetty

Comments

Shruthi Shetty M created an issue. See original summary.

shruthi_shetty’s picture

shruthi_shetty commented
Status: Active » Needs review
StatusFileSize
new Remove-calls-to-deprecated-method-assertIdentical-3034762-2.patch2.32 KB

Removed calls to deprecated method assertIdentical() and replaced with assertIdenticals()

Status: Needs review » Needs work

The last submitted patch, 2: Remove-calls-to-deprecated-method-assertIdentical-3034762-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Title: Remove calls to deprecated method assertIdentical() and replace with assertIdenticals() » Remove calls to deprecated method assertIdentical() and replace with assertSame()

Change records:
https://www.drupal.org/node/2469723

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Assigned: Unassigned » thalles
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Assigned: thalles » Unassigned
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new pathauto-Remove-calls-to-deprecated-method-assertIdentical-3034762-6-D8.patch2.3 KB
new interdiff-3034762-2-6.txt2.09 KB

Follow the patch!

amarphule’s picture

amarphule commented
Assigned: Unassigned » amarphule
Issue summary: View changes
amarphule’s picture

amarphule commented
Assigned: amarphule » Unassigned
StatusFileSize
new remove-calls-to-deprecated-method-assertIdentical-replace-asserSame-3034762-8.patch26.92 KB
new interdiff_6-8.txt26.29 KB

Created a new patch and added interdiff. Changed assertIdentical() to assertSame() and assertEqual() to assertEquals().
patch works for me on D8.6.15, php 7.3 mysql-5.7 and pathauto 8.x-1.x

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

The last patch is massive and seems to be doing a lot of unrelated changes as well?

nitvirus’s picture

nitvirus commented
Status: Needs work » Fixed

We should close this one as this is already commit in 8.x.1.x branch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.