Problem/Motivation

The dvg_popup module introduces a dvg_popup_config variable, but this variable is not removed when the module is uninstalled.

Proposed resolution

Remove the dvg_popup_config variable when the dvg_popup module is uninstalled.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

CommentFileSizeAuthor
#4 3034088-4.patch356 bytesmegha_kundar
#3 delete_variable-3034088-2.patch341 bytesggh

Comments

idebr created an issue. See original summary.

megha_kundar’s picture

megha_kundar commented
Status: Active » Needs review
StatusFileSize
new 3034088-2.patch430 bytes

Implemented the hook_unistall function using which we will remove the variable dvg_popup_config.

ggh’s picture

ggh commented
StatusFileSize
new delete_variable-3034088-2.patch341 bytes

Patch created, please verify

megha_kundar’s picture

megha_kundar commented
StatusFileSize
new 3034088-4.patch356 bytes

Modified Previous patch

paulvandenburg’s picture

paulvandenburg commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch(es).
I've applied #3 as that one has the correct white space formatting.

  • paulvandenburg committed 671c777 on 7.x-1.x 
    Issue #3034088 by Megha_kundar, GGH: dvg_popup_config not removed on...
paulvandenburg’s picture

paulvandenburg commented
Status: Reviewed & tested by the community » Fixed
paulvandenburg’s picture

paulvandenburg commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.