A script refers to a repo that is outdated and read only https://github.com/drupal-media/embed.git

In .travis-before-script.sh

# Download dependencies
mkdir -p "$DRUPAL_TI_DRUPAL_DIR/$DRUPAL_TI_MODULES_PATH"
cd "$DRUPAL_TI_DRUPAL_DIR/$DRUPAL_TI_MODULES_PATH"
git clone --depth 1 --branch 8.x-1.x https://github.com/drupal-media/embed.git

Is this file even needed? Could it be removed?

CommentFileSizeAuthor
#10 3033550-10.patch4.23 KBwim leers
#10 interdiff.txt3.61 KBwim leers
#9 3033550-9.patch811 bytesmegha_kundar
#7 innerdiff-3033550-7.patch468 bytesmegha_kundar
#4 3033550-4.patch0 bytesr.shaikh
#2 3033550-2.patch414 bytesmegha_kundar

Comments

oknate created an issue. See original summary.

megha_kundar’s picture

megha_kundar commented
Status: Active » Needs review
StatusFileSize
new 3033550-2.patch414 bytes

Removed the outdated link to repository

oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Needs review » Needs work

I think the entire file should be removed. And any travis code. It looks like travis is github specific and the project isn't using the github repos any more.

r.shaikh’s picture

r.shaikh commented
StatusFileSize
new 3033550-4.patch0 bytes

@oknate as suggested i have removed that file and its working fine.

r.shaikh’s picture

r.shaikh commented
r.shaikh’s picture

r.shaikh commented
megha_kundar’s picture

megha_kundar commented
Status: Needs work » Needs review
StatusFileSize
new innerdiff-3033550-7.patch468 bytes

removed the file travis-before-script

Status: Needs review » Needs work

The last submitted patch, 7: innerdiff-3033550-7.patch, failed testing. View results

megha_kundar’s picture

megha_kundar commented
Status: Needs work » Needs review
StatusFileSize
new 3033550-9.patch811 bytes

Removed .travis_before_script and updated .travis.yml

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Travis script refers to outdated repo » Remove Travis scripts since they're no longer used
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new interdiff.txt3.61 KB
new 3033550-10.patch4.23 KB

Given that https://travis-ci.org/drupal-media/embed last ran two years ago, going ahead and doing this. I suspect Travis was used because DrupalCI was lacking in its capabilities to install dependencies. That's no longer a problem :)

  • Wim Leers committed 2165ab2 on 8.x-1.x 
    Issue #3033550 by Megha_kundar, Wim Leers, R.shaikh, oknate: Remove...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Category: Bug report » Task
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.