Problem/Motivation

Drupal asked for injection:

  • \Drupal\Core\Extension\ModuleHandler

Proposed resolution

Inject services:

  • module_handler
CommentFileSizeAuthor
#4 conditional_fields-Drupal_dependency_injection_on_src_Conditions-3033389-4-D8.patch2.75 KBthalles
#3 conditional_fields-Drupal_dependency_injection_on_src_Conditions-3033389-3-D8.patch2.78 KBthalles
#2 conditional_fields-Drupal_dependency_injection_on_src_Conditions-3033389-2-D8.patch2.15 KBthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new conditional_fields-Drupal_dependency_injection_on_src_Conditions-3033389-2-D8.patch2.15 KB

Follow the patch!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new conditional_fields-Drupal_dependency_injection_on_src_Conditions-3033389-3-D8.patch2.78 KB

Follow a new patch!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new conditional_fields-Drupal_dependency_injection_on_src_Conditions-3033389-4-D8.patch2.75 KB

Looks me better add the defaultTheme in ConditionalFieldTestBase.php

Change records:
https://www.drupal.org/node/3083055

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Reviewed & tested by the community

It looks good to me!

  • thalles committed 11ae2ca on 8.x-1.x 
    Issue #3033389 by thalles: Drupal dependency injection on src/Conditions...
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Fixed

Thanks @paulocs!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.