Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

Status: Active » Needs review
StatusFileSize
new842 bytes

This contains a bit of guess-work.

jonathan1055’s picture

StatusFileSize
new930 bytes

Use $PROJECT_DIR not $SOURCE_DIR this time.

Status: Needs review » Needs work

The last submitted patch, 3: 3033376-3.add_drupalci_yml.coverage-report.patch, failed testing. View results

  • jonathan1055 committed 8413eec on 8.x-1.x
    Issue #3033376 by jonathan1055: Add initial drupalci.yml file with...
jonathan1055’s picture

Status: Needs work » Needs review
StatusFileSize
new415 bytes

The default drupalci config (and the default behaviour before I added drupalci.yml) attempts to run every type of test. In particular we have:

    testing:
      run_tests.standard:
        types: 'Simpletest,PHPUnit-Unit,PHPUnit-Kernel,PHPUnit-Functional'
        run_tests.js:
        concurrency: 1
        types: 'PHPUnit-FunctionalJavascript'
      nightwatchjs:

Then we get console error messages such as:

php /var/www/html/core/scripts/run-tests.sh --color --keep-results --suppress-deprecations --types "PHPUnit-FunctionalJavascript" --concurrency "1" --repeat "1" --sqlite "/var/lib/drupalci/workdir/run_tests.js/simpletest.sqlite" --dburl "mysql://drupaltestbot:drupaltestbotpw@172.18.0.4/jenkins_drupal_contrib_339955" --url "http://php-apache-jenkins-drupal-contrib-339955/subdirectory" --directory modules/contrib/scheduler
> Drupal\Core\Composer\Composer::upgradePHPUnit
   ERROR: No valid tests were specified.

and

$ cross-env BABEL_ENV=development node -r dotenv-safe/config -r babel-register ./node_modules/.bin/nightwatch --config ./tests/Drupal/Nightwatch/nightwatch.conf.js --tag=scheduler
 There was an error while starting the test runner:

As we do not have javascript tests it is cleaner to remove these attempts from drupalci.yml

  • jonathan1055 committed 340dfda on 8.x-1.x
    Issue #3033376 by jonathan1055: Do not try to run tests that do not...
jonathan1055’s picture

Title: Add drupalci.yml test file to extend d.o. testing » Add drupalci.yml test file to configure d.o. testing
Status: Needs review » Fixed

Yes! Now we do not get the errors in Jenkins console saying 'No valid tests were specified'

Calling this fixed now. There are lots of other things we can do with drupalci.yml and they can be on other issues.

jonathan1055’s picture

For the record, to temporarily limit the Scheduler phpunit tests on D.O. to a single test class, the following line can be added:

testgroups: '--class "Drupal\Tests\scheduler\Functional\NameOfTest"'

where NameOfTest is the test class. Note that the full path is case-sensitive.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jonathan1055’s picture

StatusFileSize
new530 bytes
jonathan1055’s picture

Status: Closed (fixed) » Active

Setting to active to allow tests to be run.

jonathan1055’s picture

StatusFileSize
new1.51 KB
jonathan1055’s picture

StatusFileSize
new1.15 KB
jonathan1055’s picture

StatusFileSize
new1.22 KB
jonathan1055’s picture

StatusFileSize
new1.27 KB
jonathan1055’s picture

StatusFileSize
new875 bytes
jonathan1055’s picture

Status: Active » Fixed

Ignore the above patches. Using this issue for D9 drupalci.yml patch testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.