Closed (fixed)
Project:
JSON:API
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Feb 2019 at 18:42 UTC
Updated:
11 Mar 2019 at 20:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
effulgentsia commentedComment #3
effulgentsia commentedComment #4
gabesulliceComment #5
gabesullices/PrimaryData/ResourceObjectData/ because on relationship responses, the relationship data is the primary data.
Comment #6
gabesulliceComment #7
wim leersI do like the extra type safety this gets us! The fact that they're all still
@internalmeans this is solely refactoring of implementation details that gets us type safety.(We can nail the name later, before making it non-internal.)
This looks wonderful! Just one question: why not make each concrete
Datasubclassfinal?RTBC as far as I'm concerned.
Comment #8
gabesullice#3032679: Clean-up: rename EntityCollection to Data landed. Per #7, RTBC.
Re-uploading the #6 do-not-test patch. Will commit if tests pass.
Comment #9
gabesulliceHeh, forgot to upload.
Comment #10
gabesulliceComment #12
gabesullice🎉
Comment #13
effulgentsia commentedNice!
I posted some additional questions / potential suggestions in #3035141: Cleanup: Further refinements of JsonApiResource\Data and subclasses.
Comment #14
wim leersThis introduced a regression on PHP 5: #3035676: Follow-up for #3033123: PHP 5.5 + Drupal 8.7 test runs are suddenly failing.