Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This issue is created for the small miscellaneous adjustments to bits of code in preparation for the 8.x-1.1 release which do not need their own separate issue. There are a few places which need minor changes and it is better to have these recorded against an issue number in the commit log, rather than have them invisible here and only findable when viewing the actual commit list.
Comment | File | Size | Author |
---|
Comments
Comment #2
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedFor Travis CI testing the tests now fail at Core 8.4 with
call to undefined method Drupal::messenger()
due to the recent change to use this service (which I guess does not exist in D8.4). We no longer need to test at D8.4 but should add D8.7 instead.[edit: the commit message is incorrect. Testing at core 8.5 is still done, it is 8.4 which has been dropped now]
Comment #4
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedJust for fun here's a patch from #2952984-13: Add example drupalci.yml file to un-suppress deprecations to see if we get anyrthing for code test coverage.
Comment #6
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedThe drupalci.yml file is a bigger change and now has it's own issue #3033376: Add drupalci.yml test file to configure d.o. testing
This patch adds
@group legacy
to our DevelGenerate test, because Devel is using quite a bit of deprecated code which causes test failures on Travis. This patch (and commit) will have no effect on drupal.org testing because deprecation warnings are suppressed and ignored for all contrib, see #2926314: Contrib should run with --suppress-deprecations. Also clone the 2.x branch of Devel not the 1.x branch, as that is more likely where new things will happen.Comment #9
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedTidy up test code:
$this->adminUser
Comment #13
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedCore has now released 8.8 as the latest development version and retired 8.5. Our D.O. testing already uses semantic version naming, so our default issue testing has immediately moved on to 8.8. Travis testing at 8.5 can be dropped, and 8.8 added.
Comment #15
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedAccording to docs/drupal-ci/customizing-drupalci-testing-for-projects a contrib project's drupalci.yml files should only have the
assessment
phase , and not theenvironment
andcodebase
phases.Comment #22
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedAll Travis builds started failing on 13 Aug with
There must have been some tightening up of requirements in the config, as I needed to add
which fixed it. Other modules such as Rules and Typed_data will also need this fix in their .travis.yml file.
Comment #26
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented