This issue is created for the small miscellaneous adjustments to bits of code in preparation for the 8.x-1.1 release which do not need their own separate issue. There are a few places which need minor changes and it is better to have these recorded against an issue number in the commit log, rather than have them invisible here and only findable when viewing the actual commit list.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

For Travis CI testing the tests now fail at Core 8.4 with call to undefined method Drupal::messenger() due to the recent change to use this service (which I guess does not exist in D8.4). We no longer need to test at D8.4 but should add D8.7 instead.

[edit: the commit message is incorrect. Testing at core 8.5 is still done, it is 8.4 which has been dropped now]

  • jonathan1055 committed 4141cd3 on 8.x-1.x
    Issue #3033108 by jonathan1055: Add Travis testing at core 8.7 and drop...
jonathan1055’s picture

Status: Active » Needs review
FileSize
842 bytes

Just for fun here's a patch from #2952984-13: Add example drupalci.yml file to un-suppress deprecations to see if we get anyrthing for code test coverage.

Status: Needs review » Needs work

The last submitted patch, 4: 2952984_coverage-report-13.patch, failed testing. View results

jonathan1055’s picture

Status: Needs work » Needs review
FileSize
1.66 KB

The drupalci.yml file is a bigger change and now has it's own issue #3033376: Add drupalci.yml test file to configure d.o. testing

This patch adds @group legacy to our DevelGenerate test, because Devel is using quite a bit of deprecated code which causes test failures on Travis. This patch (and commit) will have no effect on drupal.org testing because deprecation warnings are suppressed and ignored for all contrib, see #2926314: Contrib should run with --suppress-deprecations. Also clone the 2.x branch of Devel not the 1.x branch, as that is more likely where new things will happen.

  • jonathan1055 committed 09836a0 on 8.x-1.x
    Issue #3033108 by jonathan1055: Add @group legacy to DevelGenerateTest...

  • jonathan1055 committed 90245ea on 8.x-1.x
    Issue #3033108 by jonathan1055: List phpcs sniffs last in .travis.yml
    
jonathan1055’s picture

Tidy up test code:

  • Ensure no tests use hard-coded 'page' content type
  • tighten up permissions
  • do not overwrite $this->adminUser

  • jonathan1055 committed aeff4c2 on 8.x-1.x
    Issue #3033108 by jonathan1055: Improve testbase comments, add extra...

  • jonathan1055 committed dae4bd1 on 8.x-1.x
    Issue #3033108 by jonathan1055: Correct typos in comments in...
jonathan1055’s picture

Core has now released 8.8 as the latest development version and retired 8.5. Our D.O. testing already uses semantic version naming, so our default issue testing has immediately moved on to 8.8. Travis testing at 8.5 can be dropped, and 8.8 added.

  • jonathan1055 committed 0daaf6f on 8.x-1.x
    Issue #3033108 by jonathan1055: Add Travis testing at 8.8 and drop 8.5
    
jonathan1055’s picture

According to docs/drupal-ci/customizing-drupalci-testing-for-projects a contrib project's drupalci.yml files should only have the assessment phase , and not the environment and codebase phases.

  • jonathan1055 committed be5bd52 on 8.x-1.x
    Issue #3033108 by jonathan1055: Remove environment and codebase phases...

  • jonathan1055 committed a106b24 on 8.x-1.x
    Issue #3033108 by jonathan1055: Switch order of helper functions in...

  • jonathan1055 committed 174ca09 on 8.x-1.x
    Issue #3033108 by jonathan1055: Comments in BrowserTestBase
    

  • jonathan1055 committed d82ffd4 on 8.x-1.x
    Issue #3033108 by jonathan1055: Update .travis.yml for changes to core 8...

  • jonathan1055 committed de355df on 8.x-1.x
    Issue #3033108 by jonathan1055: e-mail notification in travis.yml when...

  • jonathan1055 committed da13f8e on 8.x-1.x
    Issue #3033108 by jonathan1055: Specify mysql service in .travis.yml
    
jonathan1055’s picture

Status: Needs review » Fixed

All Travis builds started failing on 13 Aug with

$ mysql -e "create database $MODULE"
ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)
The command "mysql -e "create database $MODULE"" failed and exited with 1 during .

There must have been some tightening up of requirements in the config, as I needed to add

services:
  - mysql

which fixed it. Other modules such as Rules and Typed_data will also need this fix in their .travis.yml file.

  • jonathan1055 committed 2fdb47a on 8.x-1.x
    Issue #3033108 by jonathan1055: Better version syntax for require-dev
    

  • jonathan1055 committed 78626a8 on 8.x-1.x
    Issue #3033108 by jonathan1055: Fix some spelling mistakes
    

  • jonathan1055 committed d79d4a2 on 8.x-1.x
    Issue #3033108 by jonathan1055: Use carat syntax for requirements in...
jonathan1055’s picture

Assigned: jonathan1055 » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.