Closed (fixed)
Project:
ImageCache Punch
Version:
7.x-1.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
14 Feb 2019 at 01:28 UTC
Updated:
1 Mar 2019 at 20:09 UTC
Jump to comment: Most recent
Hi,
Thanks for creating the module. It does what it's supposed to do. However, it's adding the "t" param in-between the path and the file name when adding images to the CKEditor using IMCE, resulting in broken images. Also, images in IMCE didn't load either.
The issue being that the strpos() function is checking loosely if the value is "0", and if "styles/" is not in the path "false" is returned, which both evaluates to "true". I've fixed this by adding a strict type comparison instead.
| Comment | File | Size | Author |
|---|---|---|---|
| imagecache_punch-strpos_evaluation_issue.patch | 580 bytes | enzipher |
Comments
Comment #2
enzipher commentedComment #3
heathdutton commentedWould you mind becoming a maintainer enzipher?
Comment #4
enzipher commentedNo problem. I noticed you already added me, so thanks!
Will take care of this issue (unless you're on it).
Comment #5
enzipher commentedNotice that this issue was already fixed in the dev branch, so I'll just go ahead and make a new release.