There are a few Simpletest tests that should be converted to PHPUnit tests. These are:

  • RssNodeImport::testHttpImport()
  • RssNodeImport::testCron()
  • PrivateFileTest::testPrivateFile()
CommentFileSizeAuthor
#6 interdiff-3032822-5-6.txt743 bytesmegachriz
#6 feeds-simpletest-convert-rss-node-import-3032822-6.patch18.66 KBmegachriz
#5 interdiff-3032822-4-5.txt1.42 KBmegachriz
#5 feeds-simpletest-convert-rss-node-import-3032822-5.patch18.58 KBmegachriz
#4 interdiff-3032822-3-4.txt9.16 KBmegachriz
#4 feeds-simpletest-convert-rss-node-import-3032822-4.patch17.16 KBmegachriz
#3 interdiff-3032822-2-3.txt3.02 KBmegachriz
#3 feeds-simpletest-convert-rss-node-import-3032822-3.patch8.75 KBmegachriz
#2 feeds-simpletest-convert-rss-node-import-3032822-2.patch8.09 KBmegachriz

Comments

MegaChriz created an issue. See original summary.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new feeds-simpletest-convert-rss-node-import-3032822-2.patch8.09 KB

As a start, this patch tries to convert the test RssNodeImport::testHttpImport().

megachriz’s picture

megachriz
Primary language Dutch
commented
StatusFileSize
new feeds-simpletest-convert-rss-node-import-3032822-3.patch8.75 KB
new interdiff-3032822-2-3.txt3.02 KB

I had made the patch last week, did not notice I hadn't finished yet. This patch finished the port of RssNodeImport::testHttpImport() and also enables asserting that terms get imported correctly.

megachriz’s picture

megachriz
Primary language Dutch
commented
StatusFileSize
new feeds-simpletest-convert-rss-node-import-3032822-4.patch17.16 KB
new interdiff-3032822-3-4.txt9.16 KB

This ports RssNodeImport::testCron() as well.

megachriz’s picture

megachriz
Primary language Dutch
commented
StatusFileSize
new feeds-simpletest-convert-rss-node-import-3032822-5.patch18.58 KB
new interdiff-3032822-4-5.txt1.42 KB

And the last one, which appeared to be simpler: PrivateFileTest::testPrivateFile(). That test was basically covering a bug that been in feeds_file_download() (see #2706717: PHP notice coming from feeds_file_download).

megachriz’s picture

megachriz
Primary language Dutch
commented
StatusFileSize
new feeds-simpletest-convert-rss-node-import-3032822-6.patch18.66 KB
new interdiff-3032822-5-6.txt743 bytes

Forget to change the namespace of the moved test "PrivateFileTest". Also small coding standard correction.

  • MegaChriz committed b9f63d4 on 8.x-3.x 
    Issue #3032822 by MegaChriz: Converted all Simpletest tests to PHPUnit...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Committed #6.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.